Remove neutrinos from reclustered jet collections in 14_1_X #426
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The recent pull request #423 by @hjbossi removed neutrinos from generator level jets in forest 13_2_X, which still uses legacy miniAOD jet clustering using the methods in clusterJetsFromMiniAOD_cff.py script. The jet clustering has been updated for 14_1_X, so the same fix as in 13_2_X does not work anymore in 14_1_X. Thus, the pull request #424 does not actually remove neutrinos from jets. This is now fixed in this pull request. The neutrinos are removed from all the reclustered jets, and the generator level jet collections with neutrinos included have been removed from the clustering sequence. It is also explicitly commented in the forest configuration files that without reclustering, the jets directly read from miniAOD:s currently contain neutrinos in their generator level jets.
@mandrenguyen @stahlleiton
PR validation:
Tested locally the following configurations and confirm that refpt and genpt quantities match:
forest_miniAOD_run3_MC.py
forest_miniAOD_run3_ppref_MC.py