Forest 53 x 04 jpt #2

stepobr · 2014-05-21T15:57:04Z

Here's a pull request to add JetPlusTrack algorithm to HiForest. Everything is done similarly to all other jet algorithms that are present in HiForest. All the changes should allow to use JPT out of the box, except the fact that JEC are not done at the PatJetProducer step. For the moment we'll be using on-fly corrections after the foresting
I was forced to put a track efficiency table CMSSW_538HI_TrackNonEff.txt in JetAnalysis/python/jets, since it isn't present in CondFormats/JetMETObjects (CMSSW_5_3_X)

…into forest_53X_04_jpt

harmonicoscillator · 2014-06-02T15:48:11Z

Is anyone looking at this? I'm not sure what JetPlusTrack means, have you talked with the highPt group already?

stepobr · 2014-06-03T11:50:55Z

Hello,

Yes, Yetkin proposed me to proceed with github after I mentioned that I want to include another jet energy correction algorithm into HIForest.
Let me know if there's any questions/comments,

Thanks,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 02 June 2014 17:48
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Is anyone looking at this? I'm not sure what JetPlusTrack means, have you talked with the highPt group already?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-44854473.

harmonicoscillator · 2014-06-03T12:15:16Z

Okay, you probably want to bother Yetkin some more about this. It looks
like your pull request is not safely merge-able, so you either need to
rebase/merge on our usual foresting branch or something more serious is
required.

Alex

On Tue, Jun 3, 2014 at 1:50 PM, stepobr [email protected] wrote:

Hello,

Yes, Yetkin proposed me to proceed with github after I mentioned that I
want to include another jet energy correction algorithm into HIForest.
Let me know if there's any questions/comments,

Thanks,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 02 June 2014 17:48
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Is anyone looking at this? I'm not sure what JetPlusTrack means, have you
talked with the highPt group already?

—
Reply to this email directly or view it on GitHub<
https://github.com/CmsHI/cmssw/pull/2#issuecomment-44854473>.

—
Reply to this email directly or view it on GitHub
#2 (comment).

yetkinyilmaz · 2014-06-03T12:27:30Z

I am very sorry guys, I am away these days, but Alex is right, we gotta be careful about merging. The whole point of using github is to communicate well line-by-line how things are supposed to be implemented, so if anybody can give specific comments in specific lines until I become available, that would be of help.

In the meanwhile I suggest we all learn everything: we should all know what JPT is, we should all know what is the approach for JECs, PAT, and ntuples in our analysis workflows, our strategies for development, etc, so that we do not rely on single person.

Stepan, maybe you can start studying these and try to get a picture of how our development works? And Alex, can you motivate yourself and some other people to become masters of how everything works?

Thanks.

On Jun 3, 2014, at 3:15 PM, "R. Alex Barbieri" [email protected] wrote:

Okay, you probably want to bother Yetkin some more about this. It looks
like your pull request is not safely merge-able, so you either need to
rebase/merge on our usual foresting branch or something more serious is
required.

Alex

On Tue, Jun 3, 2014 at 1:50 PM, stepobr [email protected] wrote:

Hello,

Yes, Yetkin proposed me to proceed with github after I mentioned that I
want to include another jet energy correction algorithm into HIForest.
Let me know if there's any questions/comments,

Thanks,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 02 June 2014 17:48
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Is anyone looking at this? I'm not sure what JetPlusTrack means, have you
talked with the highPt group already?

—
Reply to this email directly or view it on GitHub<
https://github.com/CmsHI/cmssw/pull/2#issuecomment-44854473>.

—
Reply to this email directly or view it on GitHub
#2 (comment).

—
Reply to this email directly or view it on GitHub.

stepobr · 2014-06-03T12:28:45Z

Ok I see, that's probably because besides a few new files there are modifications done to runForest_xxx.py.
Should I use forest_53X_04 as your usual foresting branch? And should I then make a new branch, after forking CmsHI/cmssw?
I would try to rebase and meanwhile ask Yetkin if I'm doing everything right.

Cheers,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 03 June 2014 14:15
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Okay, you probably want to bother Yetkin some more about this. It looks
like your pull request is not safely merge-able, so you either need to
rebase/merge on our usual foresting branch or something more serious is
required.

Alex

On Tue, Jun 3, 2014 at 1:50 PM, stepobr [email protected] wrote:

Hello,

Yes, Yetkin proposed me to proceed with github after I mentioned that I
want to include another jet energy correction algorithm into HIForest.
Let me know if there's any questions/comments,

Thanks,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 02 June 2014 17:48
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Is anyone looking at this? I'm not sure what JetPlusTrack means, have you
talked with the highPt group already?

—
Reply to this email directly or view it on GitHub<
https://github.com/CmsHI/cmssw/pull/2#issuecomment-44854473>.

—
Reply to this email directly or view it on GitHub
#2 (comment).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-44956677.

harmonicoscillator · 2014-06-03T12:37:29Z

Hey Stepan,

Yes, forest_53X_04 is the branch you should be basing your work on. If you
ping me I can offer technical assistance, Yetkin seems over-subscribed
these days. Since I'm unfamiliar with what JetPlusTrack is from a physics
standpoint could you send me an explanation (not on github) or point me
toward some documentation?

Yetkin - Kurt, Chris, I, and a few others are slowly planning a
re-organization of the HiForest. We'll let you know when we have some
concrete time and plans.

Alex

On Tue, Jun 3, 2014 at 2:28 PM, stepobr [email protected] wrote:

Ok I see, that's probably because besides a few new files there are
modifications done to runForest_xxx.py.
Should I use forest_53X_04 as your usual foresting branch? And should I
then make a new branch, after forking CmsHI/cmssw?
I would try to rebase and meanwhile ask Yetkin if I'm doing everything
right.

Cheers,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 03 June 2014 14:15
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Okay, you probably want to bother Yetkin some more about this. It looks
like your pull request is not safely merge-able, so you either need to
rebase/merge on our usual foresting branch or something more serious is
required.

Alex

On Tue, Jun 3, 2014 at 1:50 PM, stepobr [email protected] wrote:

Hello,

Yes, Yetkin proposed me to proceed with github after I mentioned that I
want to include another jet energy correction algorithm into HIForest.
Let me know if there's any questions/comments,

Thanks,

Stepan

From: R. Alex Barbieri [[email protected]]
Sent: 02 June 2014 17:48
To: CmsHI/cmssw
Cc: Stepan Obraztsov
Subject: Re: [cmssw] Forest 53 x 04 jpt (#2)

Is anyone looking at this? I'm not sure what JetPlusTrack means, have
you
talked with the highPt group already?

—
Reply to this email directly or view it on GitHub<
https://github.com/CmsHI/cmssw/pull/2#issuecomment-44854473>.

—
Reply to this email directly or view it on GitHub
#2 (comment).

—
Reply to this email directly or view it on GitHub<
https://github.com/CmsHI/cmssw/pull/2#issuecomment-44956677>.

—
Reply to this email directly or view it on GitHub
#2 (comment).

harmonicoscillator · 2014-06-03T12:48:21Z

Also for now please don't edit the runForest*.py configurations - make a new one with 'JPT' in the name. That should solve most of the merge conflicts and also means people aren't accidentally running your new algorithm before it is tested for memory leaks etc.

harmonicoscillator · 2014-06-03T12:48:45Z

@kurtejung are you involved with this?

kurtejung · 2014-06-03T14:29:03Z

Unfortunately not - this is the first I'm hearing about the JPT algorithm. Any documentation that you have would be very useful though. I also have some time to help if people need it.

Brian W testing pull request

Jgomez2 02

…ew_cond removed setting of the HcalTopology object from the HcalZDCLowGainFracti...

PRToFixMess_RPCDigitizerForUpgrade75XPR_v2

Update effAreaPhotons_cone03_pfNeutralHadrons_V2.txt

thanks for getting this sorted

tighting the seed crystal matching

use edm::one module to be MT safe

…2-8_0_X CTPPS: bug fix #2 in run ranges for FEDs channels mapping

…phase1 Add filldescriptions and remove warning

fixed the code-format in CSCRawToDigi from scram build code-format

Add SC jets from extended tracks to event content.

* added EXOLLPJetHCAL skim (initial version) * added test script test_EXOLLPJetHCAL_SKIM.py * Replace cout with edm::Logverbatim in Geometry/GlobalTrackingGeometryBuilder * Re-enable unit tests for ASAN build * dd4hep phase2 wf * Add wf *.81 for BPH DQM * Added utility script edmFileInPath * improve unt test; use edmFileInPath; convert to bash * Replace std::cout with edm::LogVerbatim in Geometry/HcalEventSetup and Geometry/HcalTestBeamData. Also add some missing files needed for testing * Code check * Remove FWCore TestHelper utility * Add ap_data type for GT interface Update GMT emulator for new ap format Also clean up the config file Update Z0/D0 according to GT Using 0.05 for Z0 and 0.03 for d0. update code format Bug fix in tracker muon matching Thanks to Santi for spotting this. This line was commented out by someone, likely by accident. Update the reference type to SA muons * improve unit test testCreateRandomMisalignment * Add back removed data version * fix bug in computation of barycenters per partition and improve graphical display * get rid of gROOT->Reset() in GeometryComparisonPlotter.cc --------- Co-authored-by: Kiley Kennedy <[email protected]> Co-authored-by: Sunanda <[email protected]> Co-authored-by: Shahzad Malik Muzaffar <[email protected]> Co-authored-by: Norraphat <[email protected]> Co-authored-by: AdrianoDee <[email protected]> Co-authored-by: Zhenbin Wu <[email protected]> Co-authored-by: cmsbuild <[email protected]> Co-authored-by: mmusich <[email protected]> Co-authored-by: Andrew David Loeliger <[email protected]>

Fix to l1t-1109_v3

Merge from cmssw master

L1T GE0 fixes

commit a7454c6 Author: noepalm <[email protected]> Date: Mon Feb 12 14:22:51 2024 +0100 Updated binning for sigma(TOF) validation histograms Updated binning for sigma(TOF) validation histograms Updated binning for sigma(TOF) validation histograms commit e0dc3be Author: noepalm <[email protected]> Date: Wed Feb 7 16:40:42 2024 +0100 Code checks && format (#2) commit 7c70ed8 Author: noepalm <[email protected]> Date: Wed Feb 7 15:57:59 2024 +0100 Removed debug ifdef condition on print to match previous implementation commit 2e40a9f Author: noepalm <[email protected]> Date: Wed Feb 7 15:54:41 2024 +0100 Removed useless comments, files + fixed input file path for standalone MTD validation cfg file commit 199ad72 Author: noepalm <[email protected]> Date: Wed Feb 7 14:41:57 2024 +0100 Code checks && code format commit 6ec3c46 Author: noepalm <[email protected]> Date: Tue Feb 6 09:56:49 2024 +0100 Changed SigmaTof fill location in validation commit 6a0525e Author: noepalm <[email protected]> Date: Mon Feb 5 18:11:27 2024 +0100 Change input file to validation commit cb7db5b Author: noepalm <[email protected]> Date: Mon Feb 5 18:07:19 2024 +0100 Saving sigmaTOF in ps commit 00230ac Author: noepalm <[email protected]> Date: Mon Feb 5 15:32:11 2024 +0100 Removed useless prints + created member vector in TrackSegments to allocate memory for sigmaTof once commit fdd6e31 Author: noepalm <[email protected]> Date: Tue Jan 9 16:08:46 2024 +0100 Added sigma(p) to TrackSegments; added sigma(TOF) computation, now saved to event commit 7d488e0 Author: noepalm <[email protected]> Date: Wed Dec 6 14:24:26 2023 +0100 testing files commit 88f9847 Author: noepalm <[email protected]> Date: Mon Feb 12 12:42:15 2024 +0100 Replaced isnan, isinf with edm::isNotFinite in MTD vertex validation

stepobr added 14 commits April 30, 2014 10:56

including JPT

82fee33

including JPT

5a3be89

including JPT

9c800c7

including JPT

27c0bad

including JPT

e4d412c

including JPT

2487424

Delete Fall12_V5_DATA.db

0a08cd7

Delete Fall12_V5_MC.db

8a52e54

Delete runForest_jpt_data.py

cb49d37

Delete runForest_jpt_mc.py

53cc593

including JPT

73dd8c8

Merge branch 'forest_53X_04_jpt' of https://github.com/stepobr/cmssw …

796fd00

…into forest_53X_04_jpt

including JPT

32d9fb3

including JPT

03601fa

stepobr closed this Jun 5, 2014

mguilbau pushed a commit that referenced this pull request Jun 20, 2014

Merge pull request #2 from blwiner/mydevel-branch

058ddc9

Brian W testing pull request

harmonicoscillator pushed a commit that referenced this pull request Jun 20, 2014

pass #2 on HI jet algo

df7de47

mguilbau pushed a commit that referenced this pull request Jun 20, 2014

Preparation for EcalUnpackerWorker removal, try #2.

a0a362c

yetkinyilmaz added a commit that referenced this pull request Sep 3, 2014

Merge pull request #2 from jgomez2/jgomez2_02

c723070

Jgomez2 02

mandrenguyen pushed a commit that referenced this pull request Sep 22, 2014

Removed unused and commented code #2

6d51c3b

yetkinyilmaz referenced this pull request in rkunnawa/cmssw Jan 30, 2015

Merge pull request cms-sw#2 from audrium/audrium/ZDCLowGainFraction_n…

2f23fdc

…ew_cond removed setting of the HcalTopology object from the HcalZDCLowGainFracti...

ssanders50 pushed a commit that referenced this pull request May 5, 2015

Merge pull request #2 from cms-sw/CMSSW_7_5_X

6740e78

PRToFixMess_RPCDigitizerForUpgrade75XPR_v2

dgulhan pushed a commit that referenced this pull request Oct 28, 2015

Merge pull request #2 from skyriacoCMS/patch-1

34203f9

Update effAreaPhotons_cone03_pfNeutralHadrons_V2.txt

kurtejung pushed a commit that referenced this pull request Oct 28, 2016

fix indentation #2

806b470

kurtejung pushed a commit that referenced this pull request Jun 12, 2017

Merge pull request #2 from rafaellopesdesa/Sam-Harper/GSIssueFix

c69575c

thanks for getting this sorted

kurtejung pushed a commit that referenced this pull request Jun 12, 2017

Merge pull request #2 from Sam-Harper/GSIssueFixPATcustomize

d60236a

tighting the seed crystal matching

kurtejung pushed a commit that referenced this pull request Jun 12, 2017

Merge pull request #2 from jhgoh/ParticleLevelProducer_80X

d03a4b8

use edm::one module to be MT safe

kurtejung pushed a commit that referenced this pull request Jun 12, 2017

Merge pull request cms-sw#18732 from forthommel/ctpps-runranges_patch…

98f6ae0

…2-8_0_X CTPPS: bug fix #2 in run ranges for FEDs channels mapping

kurtejung pushed a commit that referenced this pull request Oct 9, 2017

Merge pull request #2 from kpedro88/update-HcalSeverityLevelComputer-…

7f06d21

…phase1 Add filldescriptions and remove warning

mitaylor pushed a commit to mitaylor/cmssw that referenced this pull request Sep 21, 2022

Merge pull request CmsHI#2 from tahuang1991/HMT_emulation_12_5_X

b6a117e

fixed the code-format in CSCRawToDigi from scram build code-format

mandrenguyen pushed a commit that referenced this pull request Jun 24, 2023

Merge pull request #2 from EmyrClement/bTagNN_addExtSCJets_master

75130d6

Add SC jets from extended tracks to event content.

mandrenguyen pushed a commit that referenced this pull request Jun 24, 2023

Merge pull request #2 from folguera/FixTo_epalencia_l1t-1109_v3

53419b9

Fix to l1t-1109_v3

mandrenguyen pushed a commit that referenced this pull request Jun 24, 2023

Merge pull request #2 from cms-sw/master

26aee51

Merge from cmssw master

jusaviin pushed a commit that referenced this pull request Sep 9, 2024

Merge pull request #2 from watson-ij/l1t-pr-fixes

48b6441

L1T GE0 fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forest 53 x 04 jpt #2

Forest 53 x 04 jpt #2

stepobr commented May 21, 2014

harmonicoscillator commented Jun 2, 2014

stepobr commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

yetkinyilmaz commented Jun 3, 2014

stepobr commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

kurtejung commented Jun 3, 2014

Forest 53 x 04 jpt #2

Forest 53 x 04 jpt #2

Conversation

stepobr commented May 21, 2014

harmonicoscillator commented Jun 2, 2014

stepobr commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

yetkinyilmaz commented Jun 3, 2014

stepobr commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

harmonicoscillator commented Jun 3, 2014

kurtejung commented Jun 3, 2014