Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the FileAudit test in CTS for systemd systems #3809

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Fix the FileAudit test in CTS for systemd systems #3809

merged 4 commits into from
Feb 3, 2025

Conversation

clumens
Copy link
Contributor

@clumens clumens commented Jan 23, 2025

After:

Jan 23 16:25:27 Cluster nodes:
Jan 23 16:25:27 * rhel9-ctslab-1
Jan 23 16:25:27 * rhel9-ctslab-2
Jan 23 16:25:27 * rhel9-ctslab-3
Jan 23 16:25:31 Warning: Core file on rhel9-ctslab-1: Thu 2025-01-23 16:25:03 EST 834 0 0 SIGSEGV none /root/crash -
Jan 23 16:25:33 Audit FileAudit FAILED.

nrwahl2
nrwahl2 reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@nrwahl2 nrwahl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some comments but nothing needs to change.

python/pacemaker/_cts/audits.py Show resolved Hide resolved
python/pacemaker/_cts/audits.py Show resolved Hide resolved
python/pacemaker/_cts/audits.py Outdated Show resolved Hide resolved
@clumens
Copy link
Contributor Author

clumens commented Jan 31, 2025

Updated to address review comments. All patches are worth another look.

@clumens clumens added the review: in progress PRs that are currently being reviewed label Jan 31, 2025
nrwahl2
nrwahl2 reviewed Jan 31, 2025
View reviewed changes
python/pacemaker/_cts/audits.py Outdated Show resolved Hide resolved
python/pacemaker/_cts/audits.py Show resolved Hide resolved
python/pacemaker/_cts/audits.py Outdated Show resolved Hide resolved
@clumens
Low: python: Use coredumpctl to check for core files.
b9b5eab 
If we're running on a system that supports systemd, core dumps will be
managed using coredumpctl.  We need to use that tool to figure out if
there are any core dumps instead of looking in various directories.

Unfortunately, this also means we won't know whether a pacemaker-related
tool wrote a core dump or not.  They'll all be in the journal by binary
name, which means we would have to search for every pacemaker or
corosync binary possible.

However, it seems likely that ctslab is being run on a dedicated system
and so if there are any core dumps present, they likely came from
pacemaker or something it relies upon.  So it's probably fine to just
check for any core dumps and warn if one is found.

Fixes T651
@clumens
Refactor: cts: _find_core_on_fs can now take a list of locations.
35d5850
@nrwahl2 nrwahl2 merged commit 0f7d244 into ClusterLabs:main Feb 3, 2025
1 check passed
@clumens clumens deleted the fileaudit branch February 3, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrwahl2 nrwahl2 nrwahl2 approved these changes

Assignees
No one assigned
Labels
review: in progress PRs that are currently being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clumens @nrwahl2