wip: t882 #3773
wip: t882 #3773
Conversation
| Test("Set stonith-enabled=false", "crm_attribute -n stonith-enabled -v false", | ||
| update_cib=True), | ||
| Test("Configure the initial resource", "cibadmin -M -o resources -p", | ||
| update_cib=True, stdin=resource_cib), | ||
| update_cib=True, stdin=resource_cib1), | ||
| Test("Upgrade to latest CIB schema (trigger 2.10.xsl + the wrapping)", | ||
| "cibadmin --upgrade --force -V -V", | ||
| update_cib=True), |
There was a problem hiding this comment.
Remember to run make to generate a new cts-cli program, and then run cts/cts-cli -s -r acls. This will generate a new regression output file. That change should also be included as a new patch in this PR.
There was a problem hiding this comment.
Make sure to give your commits a first single line that explains very briefly what is going on. We use these first lines when building the changelog for release. You can use git log <name of file> to get examples of what kinds of things to do. Also make sure to add Fixes T882 to one of them because our integration with phorge keys off this.
| @@ -0,0 +1,24 @@ | |||
| <cib crm_feature_set="3.19.5" validate-with="pacemaker-1.3" epoch="2" num_updates="0" admin_epoch="0"> | |||
There was a problem hiding this comment.
pacemaker-1.3 is a valid schema - if the idea here is to test a schema version that doesn't exist, you should change this to something that's not in xml/pacemaker-*. Maybe 1.4, or 2.999, or something like that.
|
|
||
| TestGroup(t882_tests3, | ||
| env={"CIB_file": "{cts_cli_data}/cibadmin_invalid_schema.xml"}), | ||
|
|
There was a problem hiding this comment.
You're not adding tests0, tests1, or tests2 to basic_tests so they will never be run. I think you were just experimenting with different ways of providing the input for the tests, right? In general, we're doing a pretty good job of testing that already so I think it's okay if you just use a single method here and remove all the others. In that case, you can also get rid of resource_cib2 because it's just duplicating what's in the XML file you add in a later patch.
|
Oh, you can remove the draft status from this so we can get CI running on it. |
No description provided.