Med: libcrmcommon/iso8601: fix train of thinkos regarding time offsets #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaillot
reviewed
Dec 12, 2022
There was a problem hiding this comment.
I'm thinking the code base has changed enough that it's now misleading to say that poki authored this, so you should commit your changes fresh and just mention in the comment that it's a forward-port of work he originally did
Rebasing this on current main should clarify it a bit
waltdisgrace
force-pushed
the
t188
branch
3 times, most recently
from
f385829 to
a8e1621
Compare
Due to a bug, timezone-containing format strings were were being parsed incorrectly in the following ways: - White space was optional when it should've been forbidden, e.g. +02 00 got parsed as if it were +0200. - White space was required when it should've been optional, e.g. no timezone in "2019-04-25T21:42:54+0200" got parsed, whereas a timezone in "2019-04-25T21:42:54 +0200" got parsed. - Timezones beginning with a '+' were parsed incorrectly, e.g. +0200 got parsed as +0020 due to '+' "consuming" a position. In the future, we should use a library such as glib's GDateTime (https://developer.gnome.org/glib/stable/glib-GDateTime.html#g-date-time-new-from-iso8601) and update any necessary schema pocedures. This PR was initially authored by jnpkrn and heavily edited by me to reflect the current code base. closes T188
|
Doh, I completely overlooked the last changes to this PR :-/ Sorry for letting this linger so long ... Closing this since the code base has changed significantly, and it will need a rebase and re-review, so a new PR would be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes T188