-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus best practices, TLS and basic auth support #200
Merged
stefanotorresi
merged 8 commits into
ClusterLabs:master
from
yeoldegrove:packages_and_tls
May 24, 2022
Merged
prometheus best practices, TLS and basic auth support #200
stefanotorresi
merged 8 commits into
ClusterLabs:master
from
yeoldegrove:packages_and_tls
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions inline just to remind myself, let's have a chat face to face to discuss some of the more extensive changes.
(switch logrus to promlog, switch pflag to kingpin)
yeoldegrove
force-pushed
the
packages_and_tls
branch
from
May 24, 2022 13:28
e08c01a
to
d120241
Compare
@stefanotorresi force pushed the changes you wanted. It is ready to merged from my point of view. |
stefanotorresi
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point was to enable TLS support.
One pre-requisite for this was a
log.Logger
object (reference) which is not available in the currently used logging packagelogrus
.I took this as an opportunity to port some best practices from e.g. HAProxy exporter and MySQL Server exporter. This includes:
viper
config and overwrite it withkinpin
flagspromu
945cbc1In addition to that, the OBS + release CI is kind of broken at the moment. These commits tend to fix it: