Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT REVIEW OR MERGE] Move pyrsistent serialization and hashing helpers to a new module. #2858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wallrj
Copy link
Contributor

@wallrj wallrj commented Jul 7, 2016

Here's an idea for re-organizing the serialization stuff so that I can e.g. use wire_encode from _diffing in #2839.

Unfortunately it's not quite enough.

Perhaps instead, wire_decode should accept an acceptable_classes argument rather than having the global SERIALIZABLE_CLASSES variable.
After all we'd never expect to find _diffing classes in the control service configuration which also uses the wire_encode format.

Needs more thought.

@Azulinho
Copy link
Contributor

I think you can do a lot better than this, seriously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants