Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-17021: add NoExecute toleration #46

Merged
merged 1 commit into from
Mar 6, 2024
Merged

CP-17021: add NoExecute toleration #46

merged 1 commit into from
Mar 6, 2024

Conversation

dmepham
Copy link
Contributor

@dmepham dmepham commented Mar 6, 2024

Description of the change

Some users may have this taint on their nodes, and it may reduce some confusion to allow these pods to tolerate them. there may be instances where k8s admins may want to customize these tolerations, but the majority should probably want both

Type of change

  • Bug fix
  • New feature

Checklists

Development

  • All changed code has 80% unit test coverage
  • All changed code has been automatically (smoke test or otherwise) or manually verified in alfa (or with a cross namespace setup, e.g. developer namespace for this feature, pointing at shared alfa resources)

Code review

  • This pull request has a title that includes the ticket # and a short useful summary, e.g. CP-4051: Create TEMPLATE Feature Repo.

@dmepham dmepham requested a review from a team as a code owner March 6, 2024 18:01
roberthocking
roberthocking approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@roberthocking roberthocking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dmepham dmepham merged commit e476049 into develop Mar 6, 2024
1 check passed
@dmepham dmepham deleted the example-toleration branch March 6, 2024 18:40
dmepham added a commit that referenced this pull request Mar 7, 2024
@dmepham
CP-17021: add NoExecute toleration (#46)
7e3a4d5 
adds toleration
dmepham added a commit that referenced this pull request Mar 7, 2024
@dmepham
V0.0.29 release (#49)
d3d57d6 
* Update cloudwatch agent README with sampling rate information (#45)

* CP-17021: add NoExecute toleration  (#46)

adds toleration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthocking roberthocking roberthocking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmepham @roberthocking