Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self-signed ca certs with EcDSA and Ed25519 #234

Merged

Conversation

cviecco
Copy link
Contributor

@cviecco cviecco commented Jun 4, 2024

The current implementation only worked for P-256 and rsa keys, because we had a harcoded hash type. Makes the hash type dependent on the publicKey (which is derived from the public one).

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.17%. Comparing base (efb227d) to head (ff06b61).

Files Patch % Lines
lib/certgen/certgen.go 59.09% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   32.13%   32.17%   +0.04%     
==========================================
  Files          75       75              
  Lines        9730     9739       +9     
==========================================
+ Hits         3127     3134       +7     
- Misses       5962     5963       +1     
- Partials      641      642       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cviecco cviecco merged commit 5fd5e96 into Cloud-Foundations:master Jun 6, 2024
9 checks passed
@cviecco cviecco deleted the enhance-certgent-self-signed-ca branch June 6, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants