Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 17 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 17 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Dec 21, 2024

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to the default branch since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to the default branch. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @lindsgiles22

Integer MILLISECONDS_PER_MINUTE = null; // Make this value a constant
Integer milliseconds;
return null; // Replace null with the variable you used to store the result
Integer MILLISECONDS_PER_MINUTE = 60000;

Check failure

Code scanning / PMD

Configurable naming conventions for local variable declarations. This rule reports variable declarations which do not match the regex that applies to their specific kind (e.g. local variable, or final local variable). Each regex can be configured through properties. By default this rule uses the standard Apex naming convention (Camel case). Error

The local variable name 'MILLISECONDS_PER_MINUTE' doesn't match '[a-z][a-zA-Z0-9]*'
@@ -291,8 +386,26 @@
* @return A Decimal representing the monthly paycheck.
*/
public static Decimal calculateMonthlyPaycheck(Decimal hourlyRate, Double numberOfHours) {
return null; // Replace null with the variable you used to store the result
final Integer NUMBER_OF_WEEKLY_PAYCHECKS = 4;

Check failure

Code scanning / PMD

Configurable naming conventions for local variable declarations. This rule reports variable declarations which do not match the regex that applies to their specific kind (e.g. local variable, or final local variable). Each regex can be configured through properties. By default this rule uses the standard Apex naming convention (Camel case). Error

The final local variable name 'NUMBER_OF_WEEKLY_PAYCHECKS' doesn't match '[a-z][a-zA-Z0-9]*'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant