Added requirements file to config zip and GUI view of requirements #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RishabhJain2018
requested changes
Sep 8, 2021
There was a problem hiding this comment.
@vinceli1004 Can you please add the description for the PR mainly what this PR adds and what is the approach for it.
Added! |
Ram81
requested changes
Sep 8, 2021
apps/challenges/migrations/0091_remove_challenge_requirements.py
Outdated
Show resolved
Hide resolved
vinceli1004
changed the title
Ram81
requested changes
Sep 15, 2021
There was a problem hiding this comment.
@vinceli1004 can we remove the API based on our discussion.
apps/challenges/views.py
Outdated
| @@ -2603,6 +2603,60 @@ def get_challenge_phases_by_challenge_pk(request, challenge_pk): | |||
| return Response(response_data, status=status.HTTP_200_OK) | |||
|
|
|||
|
|
|||
| @api_view(["GET"]) | |||
| @throttle_classes([AnonRateThrottle]) | |||
| def get_challenge_requirements_by_challenge_pk(request, challenge_pk): | |||
There was a problem hiding this comment.
@vinceli1004 can we remove this API
apps/challenges/urls.py
Outdated
| @@ -151,6 +151,11 @@ | |||
| views.get_challenge_phases_by_challenge_pk, | |||
| name="get_challenge_phases_by_challenge_pk", | |||
| ), | |||
| url( | |||
There was a problem hiding this comment.
@vinceli1004 can we remove this API
RishabhJain2018
approved these changes
Sep 20, 2021
vaheta
pushed a commit
to vahetag/EvalAI
that referenced
this pull request
Dec 10, 2024
…iew of requirements (Cloud-CV#3593) * completed requirements task * make default for requirements empty * made requirements.txt part of the evaluation_script folder * style changes * responding to comments * added fixes for missed comments * removed unused variable * frontend changes removed * removed requirements api, clarified worker error message Co-authored-by: Rishabh Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add a requirements.txt file for custom challenge package installation.
Approach:
The submission worker, upon extracting the challenge configuration zip, checks for a requirements.txt file and attempts to install its contents with a subprocess call. Any issues are logged.
An API was added to get the requirements given the challenge id, and this was used to display the requirements on a challenge's manage page.