Move test annotations to edit phase section #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautamjajoo
requested review from
Ram81 and
Kajol-Kumari
and removed request for
Ram81
gautamjajoo
requested review from
Ram81 and
Kajol-Kumari
and removed request for
Kajol-Kumari and
Ram81
Ram81
requested changes
Sep 7, 2021
There was a problem hiding this comment.
@gautamjajoo can we make following changes
-
Add more space between the
Noteand theTest annotations uploadoption. -
Move the
Xbutton to the right side of the modal and align it on the same line asInstructions. Can you also check if the font size for headingInstructionsis consistent with font size used for other modals.
-
The File upload option has a very large file upload component. Can we please reduce it's width. Same for upload evaluation script as well
|
@Ram81 Done the required changes! Here are the screenshots:
|
vaheta
pushed a commit
to vahetag/EvalAI
that referenced
this pull request
Dec 10, 2024
* move test annotations outside the modal * change font light and remove line break * fix modal width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ram81 @Kajol-Kumari
In continuation with #3570