Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Worker] Enable cilium network policy for code upload evaluation #3578

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

Ram81
Copy link
Member

@Ram81 Ram81 commented Aug 22, 2021

Description

This PR -

  • Enables cilium network policy in code upload evaluation setup to only allow connections from job pods to EvalAI and archive.ubuntu.com (to setup ubuntu packages for init-container).
  • Add additional log statements in worker setup

Changes verified using worker setup on EC2 instance.

@codecov-commenter
Copy link

Codecov Report

Merging #3578 (b8a1d7f) into master (96968d6) will decrease coverage by 1.42%.
The diff coverage is 33.52%.

@@            Coverage Diff             @@
##           master    #3578      +/-   ##
==========================================
- Coverage   72.93%   71.50%   -1.43%     
==========================================
  Files          83       20      -63     
  Lines        5368     3239    -2129     
==========================================
- Hits         3915     2316    -1599     
+ Misses       1453      923     -530     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.51% <32.16%> (-10.19%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.51% <32.16%> (-10.19%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06dd45...b8a1d7f. Read the comment docs.

@Ram81 Ram81 changed the title [CodeUploadWorker] Enable cilium network policy [Worker] Enable cilium network policy for code upload evaluation Aug 22, 2021
@@ -8,6 +8,7 @@ spec:
{}
egress:
- toFQDNs:
- matchName: archive.ubuntu.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different values for the same parameter name matchName?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram81 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RishabhJain2018 we are adding multiple entries for matchName to allow access to different FQDNs. We need access to archive.ubuntu.com for our pre-start hook (the hook that updates submission evaluation started at)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see..okay.

@RishabhJain2018
Copy link
Member

Also, what was the issue with Cilium initially?

@Ram81
Copy link
Member Author

Ram81 commented Aug 23, 2021

@RishabhJain2018 the cilium issue comes up when we deploy workers on fargate. This PR is tested by running a worker manually. I need to merge this PR to test it on fargate.

@RishabhJain2018
Copy link
Member

Got it!

@RishabhJain2018 RishabhJain2018 merged commit f44061a into Cloud-CV:master Aug 23, 2021
vaheta pushed a commit to vahetag/EvalAI that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants