-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Worker] Enable cilium network policy for code upload evaluation #3578
Conversation
@@ -8,6 +8,7 @@ spec: | |||
{} | |||
egress: | |||
- toFQDNs: | |||
- matchName: archive.ubuntu.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different values for the same parameter name matchName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ram81 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RishabhJain2018 we are adding multiple entries for matchName
to allow access to different FQDNs. We need access to archive.ubuntu.com
for our pre-start hook (the hook that updates submission evaluation started at)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see..okay.
Also, what was the issue with Cilium initially? |
@RishabhJain2018 the cilium issue comes up when we deploy workers on fargate. This PR is tested by running a worker manually. I need to merge this PR to test it on fargate. |
Got it! |
Co-authored-by: Rishabh Jain <[email protected]>
Description
This PR -
archive.ubuntu.com
(to setup ubuntu packages for init-container).Changes verified using worker setup on EC2 instance.