-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lazy load for images #3571
Merged
RishabhJain2018
merged 3 commits into
Cloud-CV:master
from
gautamjajoo:lazy-load-images
Sep 16, 2021
Merged
Add lazy load for images #3571
RishabhJain2018
merged 3 commits into
Cloud-CV:master
from
gautamjajoo:lazy-load-images
Sep 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RishabhJain2018
requested review from
Kajol-Kumari,
deshraj and
Ram81
and removed request for
deshraj
September 1, 2021 19:59
Ram81
approved these changes
Sep 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally, works fine
vaheta
pushed a commit
to vahetag/EvalAI
that referenced
this pull request
Dec 10, 2024
* add lazy load for images * add new line Co-authored-by: Rishabh Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds lazy loading on images and the images of the challenges are now loaded when the viewport changes, hence as the user moves down the logos are displayed.
@Ram81 @Kajol-Kumari
lazyimage.mp4