Fix console error of change in expression value #3550

gautamjajoo · 2021-07-25T17:32:44Z

Fix the error that occurs in dev mode when the change detection run twice.

Before

After
No error in console.

codecov-commenter · 2021-07-25T17:46:55Z

Codecov Report

Merging #3550 (c6ece7b) into master (96968d6) will decrease coverage by 1.45%.
The diff coverage is 32.43%.

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
- Coverage   72.93%   71.47%   -1.46%     
==========================================
  Files          83       20      -63     
  Lines        5368     3232    -2136     
==========================================
- Hits         3915     2310    -1605     
+ Misses       1453      922     -531

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	`53.91% <6.38%> (-12.95%)`	⬇️
frontend/src/js/controllers/profileCtrl.js	`79.76% <20.00%> (-13.10%)`	⬇️
frontend/src/js/controllers/permissionCtrl.js	`36.36% <22.22%> (-63.64%)`	⬇️
frontend/src/js/controllers/challengeCtrl.js	`63.41% <30.64%> (-10.29%)`	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	`82.55% <44.44%> (-10.30%)`	⬇️
frontend/src/js/controllers/challengeListCtrl.js	`95.74% <50.00%> (+1.06%)`	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	`70.50% <66.66%> (-1.18%)`	⬇️
frontend/src/js/controllers/teamsCtrl.js	`71.17% <75.00%> (ø)`
frontend/src/js/controllers/ChallengeInviteCtrl.js	`100.00% <100.00%> (ø)`
frontend/src/js/controllers/SubmissionFilesCtrl.js	`95.45% <100.00%> (ø)`
... and 30 more

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	`53.91% <6.38%> (-12.95%)`	⬇️
frontend/src/js/controllers/profileCtrl.js	`79.76% <20.00%> (-13.10%)`	⬇️
frontend/src/js/controllers/permissionCtrl.js	`36.36% <22.22%> (-63.64%)`	⬇️
frontend/src/js/controllers/challengeCtrl.js	`63.41% <30.64%> (-10.29%)`	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	`82.55% <44.44%> (-10.30%)`	⬇️
frontend/src/js/controllers/challengeListCtrl.js	`95.74% <50.00%> (+1.06%)`	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	`70.50% <66.66%> (-1.18%)`	⬇️
frontend/src/js/controllers/teamsCtrl.js	`71.17% <75.00%> (ø)`
frontend/src/js/controllers/ChallengeInviteCtrl.js	`100.00% <100.00%> (ø)`
frontend/src/js/controllers/SubmissionFilesCtrl.js	`95.45% <100.00%> (ø)`
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b05b5...c6ece7b. Read the comment docs.

Kajol-Kumari

@gautamjajoo as you have introduced the isAuth variable. Let's use this variable only at here

Rest LGTM 👍

gautamjajoo · 2021-07-26T09:21:55Z

@Kajol-Kumari I have not replaced it because first the value is false that's why the page is distorted when it is loading and then the value becomes true.

Kajol-Kumari · 2021-07-26T15:23:37Z

@Kajol-Kumari I have not replaced it because first the value is false that's why the page is distorted when it is loading and then the value becomes true.

yes @gautamjajoo but now as we are using detectChanges() so it's totally fine to use the isAuth variable in the html file

gautamjajoo · 2021-07-26T15:39:10Z

Actually, before opening the PR I tried to replace with the variable but the page is like this

Kajol-Kumari · 2021-07-26T15:51:07Z

Actually, before opening the PR I tried to replace with the variable but the page is like this

That's weird as It shouldn't happen ideally. Also, I tried doing the change on my local and it seems to work fine for me. Can you please try testing it again by replacing authService.isAuth with isAuth throughout the publiclist component html file? @gautamjajoo

gautamjajoo · 2021-07-26T15:59:06Z

@Kajol-Kumari I did change all the variables. I believe there is some issue with the changing values. Would it be better if we keep it same as authService.isAuth and consistent with other pages?

Kajol-Kumari · 2021-07-27T05:10:53Z

@Kajol-Kumari I did change all the variables. I believe there is some issue with the changing values. Would it be better if we keep it same as authService.isAuth and consistent with other pages?

yeah, we can keep this as this doing the same work but we need to figure out the reason behind it.

gautamjajoo · 2021-07-27T07:27:52Z

@Kajol-Kumari Replaced with isAuth variable, now assigning the value upon component initialization as well.

Kajol-Kumari

@gautamjajoo please format the comment for ngAfterViewChecked [The one line gap should be before comment, not after]

Rest, LGTM 👍

gautamjajoo · 2021-08-05T15:44:19Z

@Kajol-Kumari Done the changes!

Ram81

@gautamjajoo can you resolve the merge conflicts

gautamjajoo · 2021-08-16T05:55:23Z

@Ram81 Resolved the merge conflicts!

Ram81

LGTM

…opment setup(Cloud-CV#3550) * fix change in expression value * assign value on component initialization * add line Co-authored-by: Rishabh Jain <[email protected]>

fix change in expression value

fc17700

gautamjajoo mentioned this pull request Jul 25, 2021

[Refactor Code] Remove unused services and imports #3547

Merged

Kajol-Kumari approved these changes Jul 26, 2021

View reviewed changes

assign value on component initialization

f342d9c

gautamjajoo requested review from Kajol-Kumari and Ram81 July 29, 2021 09:45

Kajol-Kumari approved these changes Aug 4, 2021

View reviewed changes

add line

b8c095e

Ram81 requested changes Aug 15, 2021

View reviewed changes

Merge branch 'master' into if-dev

c6ece7b

gautamjajoo requested a review from Ram81 August 16, 2021 14:24

Ram81 approved these changes Aug 26, 2021

View reviewed changes

Ram81 added the can-be-merged label Aug 26, 2021

Merge branch 'master' into if-dev

a41448f

RishabhJain2018 merged commit d70a544 into Cloud-CV:master Aug 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix console error of change in expression value #3550

Fix console error of change in expression value #3550

gautamjajoo commented Jul 25, 2021

codecov-commenter commented Jul 25, 2021 •

edited

Loading

Kajol-Kumari left a comment

gautamjajoo commented Jul 26, 2021

Kajol-Kumari commented Jul 26, 2021

gautamjajoo commented Jul 26, 2021

Kajol-Kumari commented Jul 26, 2021

gautamjajoo commented Jul 26, 2021 •

edited

Loading

Kajol-Kumari commented Jul 27, 2021

gautamjajoo commented Jul 27, 2021

Kajol-Kumari left a comment

gautamjajoo commented Aug 5, 2021

Ram81 left a comment

gautamjajoo commented Aug 16, 2021 •

edited

Loading

Ram81 left a comment

Fix console error of change in expression value #3550

Fix console error of change in expression value #3550

Conversation

gautamjajoo commented Jul 25, 2021

codecov-commenter commented Jul 25, 2021 • edited Loading

Codecov Report

Kajol-Kumari left a comment

Choose a reason for hiding this comment

gautamjajoo commented Jul 26, 2021

Kajol-Kumari commented Jul 26, 2021

gautamjajoo commented Jul 26, 2021

Kajol-Kumari commented Jul 26, 2021

gautamjajoo commented Jul 26, 2021 • edited Loading

Kajol-Kumari commented Jul 27, 2021

gautamjajoo commented Jul 27, 2021

Kajol-Kumari left a comment

Choose a reason for hiding this comment

gautamjajoo commented Aug 5, 2021

Ram81 left a comment

Choose a reason for hiding this comment

gautamjajoo commented Aug 16, 2021 • edited Loading

Ram81 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 25, 2021 •

edited

Loading

gautamjajoo commented Jul 26, 2021 •

edited

Loading

gautamjajoo commented Aug 16, 2021 •

edited

Loading