Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons on team card #3544

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Conversation

gautamjajoo
Copy link
Member

Fixes buttons and card on teams page.
@Ram81 @Kajol-Kumari

Before
screencapture-0-0-0-0-4200-teams-participants-2021-07-23-16_57_42
screencapture-0-0-0-0-4200-teams-participants-2021-07-23-16_57_54

After
screencapture-0-0-0-0-4200-teams-participants-2021-07-23-16_51_59
screencapture-0-0-0-0-4200-teams-participants-2021-07-23-16_51_40

@codecov-commenter
Copy link

Codecov Report

Merging #3544 (ab31b7e) into master (96968d6) will decrease coverage by 0.79%.
The diff coverage is 34.17%.

@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   72.93%   72.13%   -0.80%     
==========================================
  Files          83       20      -63     
  Lines        5368     3194    -2174     
==========================================
- Hits         3915     2304    -1611     
+ Misses       1453      890     -563     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 64.61% <32.84%> (-9.08%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 29 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 64.61% <32.84%> (-9.08%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0860d8...ab31b7e. Read the comment docs.

Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RishabhJain2018 RishabhJain2018 merged commit 9eb4de3 into Cloud-CV:master Jul 24, 2021
vaheta pushed a commit to vahetag/EvalAI that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants