Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi metric leaderboard #3487

Merged
merged 6 commits into from
Aug 18, 2021
Merged

Add multi metric leaderboard #3487

merged 6 commits into from
Aug 18, 2021

Conversation

Ram81
Copy link
Member

@Ram81 Ram81 commented Jun 20, 2021

Description

  • Add boolean flag in challenge model to enable leaderboard for all metrics
  • Add leaderboard API changes to use order_by field to fetch the leaderboard if specified otherwise use default_order_by
  • Add frontend changes to show dropdown and generate separate URL for each metric

RishabhJain2018
RishabhJain2018 requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram81 Do you have a working gif of it?

apps/challenges/serializers.py Outdated
)

def get_leaderboard_schema(self, obj):
print(obj.leaderboard.schema)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the print statement?

RishabhJain2018
RishabhJain2018 requested changes Aug 3, 2021
View reviewed changes
apps/challenges/models.py Outdated Show resolved Hide resolved
@RishabhJain2018
Copy link
Member

@Ram81 Can you please resolve the conflicts here?

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021 •
edited
Loading

Codecov Report

Merging #3487 (ec882e0) into master (96968d6) will decrease coverage by 1.45%.
The diff coverage is 35.99%.

@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
- Coverage   72.93%   71.47%   -1.46%     
==========================================
  Files          83       20      -63     
  Lines        5368     3239    -2129     
==========================================
- Hits         3915     2315    -1600     
+ Misses       1453      924     -529
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.44% <35.43%> (-10.25%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.44% <35.43%> (-10.25%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) ⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7116eb1...ec882e0. Read the comment docs.

RishabhJain2018
RishabhJain2018 reviewed Aug 7, 2021
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :), Is there a screenshot of the UI?

@RishabhJain2018
Copy link
Member

@Ram81

@Ram81
Copy link
Member Author

Ram81 commented Aug 9, 2021

Screen Shot 2021-08-09 at 11 25 06 AM

Here are the screenshots
Screen Shot 2021-08-09 at 11 25 54 AM

@RishabhJain2018
Copy link
Member

RishabhJain2018 commented Aug 9, 2021 •
edited
Loading

Can we please bold (font-weight: 400) the entries by which it is ordered?

@RishabhJain2018
Copy link
Member

@Ram81 Is this PR ready to merge?

@Ram81
Copy link
Member Author

Ram81 commented Aug 18, 2021

Screenshot from 2021-08-17 21-58-04

@RishabhJain2018 this PR is ready for review. Attached a screenshot that shows a leaderboard with selected order by field column being highlighted

@RishabhJain2018 RishabhJain2018 merged commit 20ab744 into Cloud-CV:master Aug 18, 2021
@Ram81 Ram81 mentioned this pull request Sep 2, 2021
Merged
1 task
vaheta pushed a commit to vahetag/EvalAI that referenced this pull request Dec 10, 2024
@Ram81 @RishabhJain2018
Backend+Frontend: Add feature for multi metric leaderboard(Cloud-CV#3487
0b85cd5 
)

* Add multi metric leaderboard

* Fix build

* Refactor codebase

* Fix tests

* Highlight order_by column

Co-authored-by: Rishabh Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ram81 @RishabhJain2018 @codecov-commenter