Add submission cancel feature #3456

Ram81 · 2021-06-06T17:00:22Z

Description

This PR adds -

Allow user to cancel submissions if the status is SUBMITTED

codecov-commenter · 2021-06-06T17:16:12Z

Codecov Report

Merging #3456 (164a371) into master (96968d6) will decrease coverage by 1.45%.
The diff coverage is 32.43%.

@@            Coverage Diff             @@
##           master    #3456      +/-   ##
==========================================
- Coverage   72.93%   71.47%   -1.46%     
==========================================
  Files          83       20      -63     
  Lines        5368     3232    -2136     
==========================================
- Hits         3915     2310    -1605     
+ Misses       1453      922     -531

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	`53.91% <6.38%> (-12.95%)`	⬇️
frontend/src/js/controllers/profileCtrl.js	`79.76% <20.00%> (-13.10%)`	⬇️
frontend/src/js/controllers/permissionCtrl.js	`36.36% <22.22%> (-63.64%)`	⬇️
frontend/src/js/controllers/challengeCtrl.js	`63.41% <30.64%> (-10.29%)`	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	`82.55% <44.44%> (-10.30%)`	⬇️
frontend/src/js/controllers/challengeListCtrl.js	`95.74% <50.00%> (+1.06%)`	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	`70.50% <66.66%> (-1.18%)`	⬇️
frontend/src/js/controllers/teamsCtrl.js	`71.17% <75.00%> (ø)`
frontend/src/js/controllers/ChallengeInviteCtrl.js	`100.00% <100.00%> (ø)`
frontend/src/js/controllers/SubmissionFilesCtrl.js	`95.45% <100.00%> (ø)`
... and 30 more

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	`53.91% <6.38%> (-12.95%)`	⬇️
frontend/src/js/controllers/profileCtrl.js	`79.76% <20.00%> (-13.10%)`	⬇️
frontend/src/js/controllers/permissionCtrl.js	`36.36% <22.22%> (-63.64%)`	⬇️
frontend/src/js/controllers/challengeCtrl.js	`63.41% <30.64%> (-10.29%)`	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	`82.55% <44.44%> (-10.30%)`	⬇️
frontend/src/js/controllers/challengeListCtrl.js	`95.74% <50.00%> (+1.06%)`	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	`70.50% <66.66%> (-1.18%)`	⬇️
frontend/src/js/controllers/teamsCtrl.js	`71.17% <75.00%> (ø)`
frontend/src/js/controllers/ChallengeInviteCtrl.js	`100.00% <100.00%> (ø)`
frontend/src/js/controllers/SubmissionFilesCtrl.js	`95.45% <100.00%> (ø)`
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7116eb1...164a371. Read the comment docs.

RishabhJain2018

Can you please also add the screenshot of the UI?

RishabhJain2018 · 2021-06-11T15:08:13Z

apps/jobs/urls.py

@@ -110,6 +110,11 @@
        views.update_submission_started_at,
        name="update_submission_started_at",
    ),
+    url(
+        r"^challenge/(?P<challenge_pk>[0-9]+)/submissions/(?P<submission_pk>[0-9]+)/cancel/$",


Why do we need challenge_pk here? I think submission_pk should be enough here, no?

We only want the participants of the team to cancel the submission using UI. To check whether team has participated in the challenge we need challenge pk

RishabhJain2018 · 2021-06-11T15:11:42Z

apps/jobs/urls.py

@@ -110,6 +110,11 @@
        views.update_submission_started_at,
        name="update_submission_started_at",
    ),
+    url(
+        r"^challenge/(?P<challenge_pk>[0-9]+)/submissions/(?P<submission_pk>[0-9]+)/cancel/$",
+        views.change_submission_status_to_cancel,


We should create a generic API that changes the status of the submissions to other status as well.

This API is specific to the user functionality of cancelling submission. Why should this API be allowed to set other statuses?

apps/jobs/views.py

RishabhJain2018 · 2021-06-11T15:12:35Z

apps/jobs/views.py

+    """
+    API Endpoint for setting submission status to CANCELLED.
+    """
+    print(request.user, challenge_pk)


Please remove the print statement here.

@Ram81 Can you please remove it?

apps/jobs/views.py

frontend/src/js/controllers/challengeCtrl.js

RishabhJain2018 · 2021-08-01T22:50:53Z

apps/jobs/views.py

+    """
+    API Endpoint for setting submission status to CANCELLED.
+    """
+    print(request.user, challenge_pk)


@Ram81 Can you please remove it?

RishabhJain2018 · 2021-08-03T14:05:54Z

apps/jobs/views.py

+        )
+
+        try:
+            participant_team = ParticipantTeam.objects.get(pk=participant_team_pk)


Can we please use/create get_participant_model like we have for challenges/challenge phases.

RishabhJain2018 · 2021-08-03T14:06:25Z

apps/jobs/views.py

+                participant_team=participant_team,
+            )
+        except Submission.DoesNotExist:
+            response_data = {"error": "Submission does not exist"}


{"error": "Submission {} does not exist".format(submission_pk)}

RishabhJain2018 · 2021-08-03T14:06:39Z

apps/jobs/views.py

+            )
+        except Submission.DoesNotExist:
+            response_data = {"error": "Submission does not exist"}
+            return Response(response_data, status=status.HTTP_403_FORBIDDEN)


It should be 404 , no?

RishabhJain2018 · 2021-08-03T14:07:41Z

apps/jobs/views.py

+    """
+    API Endpoint for setting submission status to CANCELLED.
+    """
+    print(request.user, challenge_pk)


RishabhJain2018 · 2021-08-07T21:04:14Z

apps/jobs/views.py

+                participant_team=participant_team,
+            )
+        except Submission.DoesNotExist:
+            response_data = {"error": "Submission does not exist"}


* Add submission cancel feature * Rebase changes * Remove unused code * Fix reviews * Fix review Co-authored-by: Rishabh Jain <[email protected]>

RishabhJain2018 requested changes Jun 11, 2021

View reviewed changes

Ram81 force-pushed the cancel-sub branch from bf4528b to 19e9377 Compare June 20, 2021 10:55

RishabhJain2018 requested changes Aug 1, 2021

View reviewed changes

RishabhJain2018 requested changes Aug 3, 2021

View reviewed changes

Ram81 added 4 commits August 7, 2021 16:21

Add submission cancel feature

8c78090

Rebase changes

0a5838d

Remove unused code

425c996

Fix reviews

0047994

Ram81 force-pushed the cancel-sub branch from 19e9377 to 0047994 Compare August 7, 2021 11:06

RishabhJain2018 requested changes Aug 7, 2021

View reviewed changes

Fix review

164a371

RishabhJain2018 approved these changes Aug 8, 2021

View reviewed changes

Merge branch 'master' into cancel-sub

8901865

RishabhJain2018 merged commit c509e38 into Cloud-CV:master Aug 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add submission cancel feature #3456

Add submission cancel feature #3456

Ram81 commented Jun 6, 2021

codecov-commenter commented Jun 6, 2021 •

edited

Loading

RishabhJain2018 left a comment

RishabhJain2018 Jun 11, 2021

Ram81 Jun 12, 2021

RishabhJain2018 Jun 11, 2021

Ram81 Jun 12, 2021 •

edited

Loading

RishabhJain2018 Jun 11, 2021

RishabhJain2018 Aug 1, 2021

RishabhJain2018 Aug 3, 2021

RishabhJain2018 Aug 1, 2021

RishabhJain2018 Aug 3, 2021

RishabhJain2018 Aug 3, 2021

RishabhJain2018 Aug 7, 2021

RishabhJain2018 Aug 3, 2021

RishabhJain2018 Aug 3, 2021

RishabhJain2018 Aug 7, 2021

Add submission cancel feature #3456

Add submission cancel feature #3456

Conversation

Ram81 commented Jun 6, 2021

Description

codecov-commenter commented Jun 6, 2021 • edited Loading

Codecov Report

RishabhJain2018 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ram81 Jun 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 6, 2021 •

edited

Loading

Ram81 Jun 12, 2021 •

edited

Loading