Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count sell-outs for a product version #535

Merged
merged 1 commit into from
Jul 2, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ public class ProductVersionDTO extends NamedEntityDTO implements ProductVersionL
@ApiModelProperty( "The number of markups set for the product version" )
private long markedUp;

@ApiModelProperty( "The number of sell-outs set for the product version" )
private long soldOut;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the past tense of "sell-out", as markedUp is the past tense of "mark-up"

I read it like "how many versions have been markedUp/soldOut"


@ApiModelProperty( value = "Descriptive label of the product version", readOnly = true )
private String label;

Expand Down Expand Up @@ -533,6 +536,16 @@ public void setMarkedUp( long markedUp )
this.markedUp = markedUp;
}

public long getSoldOut()
{
return soldOut;
}

public void setSoldOut( long soldOut )
{
this.soldOut = soldOut;
}

public String getLabel()
{
return label;
Expand Down