Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription query object #242

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Add subscription query object #242

merged 3 commits into from
Feb 12, 2019

Conversation

gionn
Copy link
Contributor

@gionn gionn commented Feb 11, 2019

No description provided.

@gionn gionn self-assigned this Feb 11, 2019

public class ResellerPricingQuery extends BaseQuery
{
private static final String resellerId = "resellerId";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use UPPER_CASE for static finals

@@ -21,8 +21,8 @@
@POST( "distributorPricing" )
Call<DistributorPricingDTO> create( @Body DistributorPricingDTO dto );

@GET( "distributorPricing/{id}" )
Call<DistributorPricingDTO> get( @Path( "id" ) int id );
@GET( "distributorPricing" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you left a space here

@gionn gionn requested a review from malteo February 12, 2019 09:06
@gionn gionn merged commit d25e45d into master Feb 12, 2019
@gionn gionn deleted the split-reseller-testit branch February 12, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants