Coupon.type to enum #182
Merged
Coupon.type to enum #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
force-pushed
the
coupon-type-enum
branch
3 times, most recently
from
360f534 to
ce88d26
Compare
gionn
force-pushed
the
coupon-type-enum
branch
from
ce88d26 to
9ae079c
Compare
Mark old fields in Coupon as deprecated since this version
malteo
requested changes
Oct 16, 2018
| @Query( "product" ) Integer product, @Query( "createdAfter" ) ISO8601Date createdAfter, | ||
| @Query( "unused" ) Boolean unused, @Query( "reusable" ) boolean reusable ); | ||
|
|
||
| // TODO parameter object |
added 2 commits
October 17, 2018 15:40
Fix date format madness
malteo
reviewed
Oct 17, 2018
| @Override | ||
| public Object put( String key, Object value ) | ||
| { | ||
| if ( value == null ) return super.remove( key ); |
| import java.text.SimpleDateFormat; | ||
| import java.util.Date; | ||
|
|
||
| abstract class ClientDate |
There was a problem hiding this comment.
DateRepresentation? AbstractDateDeserializer?
malteo
previously approved these changes
Oct 18, 2018
gionn
force-pushed
the
coupon-type-enum
branch
from
f6a5da8 to
560a1ed
Compare
malteo
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.