Document marketplace #115
Merged
Document marketplace #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
suggested changes
Jun 14, 2018
| public class ResellerPricingPatchDTO extends DTO | ||
| { | ||
| @ApiModelProperty( "The defined action" ) |
There was a problem hiding this comment.
Move this as @ApiModel on enum
| @@ -25,12 +28,15 @@ | |||
| public static final String DISCOUNT_GENERATOR = "discountGenerator"; | |||
| public static final String FIXED_PRICE_GENERATOR = "fixedPriceGenerator"; | |||
|
|
|||
| @ApiModelProperty( value = "Email address to notify customer of the coupon", readOnly = true ) | |||
| @Length ( min = 48, max = 48 ) | ||
| private String hash; | ||
|
|
||
| @ApiModelProperty( value = "Human readable code of the coupon", readOnly = true ) |
| @@ -40,36 +46,46 @@ | |||
| @Valid | |||
| private UrlEntityDTO product; | |||
|
|
|||
| @ApiModelProperty( value = "Coupon type", allowableValues = "bundle, discount, extendedTrial, fixedPrice", readOnly = true ) | |||
| @NotNull | ||
| @JsonFormat( pattern = DATE_PATTERN ) | ||
| private Date creationDate = new Date(); | ||
|
|
||
| @ApiModelProperty( value = "When the coupon will expire", readOnly = true ) |
| @JsonInclude ( JsonInclude.Include.NON_NULL ) | ||
| @Min ( 0 ) | ||
| private BigDecimal newPrice; | ||
|
|
||
| @ApiModelProperty( value = "Discount percentage", readOnly = true ) |
| @JsonInclude ( JsonInclude.Include.NON_NULL ) | ||
| @Min ( 0 ) | ||
| @Max ( 100 ) | ||
| private BigDecimal percentage; | ||
|
|
||
| @ApiModelProperty( value = "Days of extension", readOnly = true ) |
| @JsonInclude ( JsonInclude.Include.NON_NULL ) | ||
| @Min ( 1 ) | ||
| private Integer days; | ||
|
|
||
| @ApiModelProperty( value = "Maximum budget for an extended trial", readOnly = true ) |
| private String state; | ||
|
|
||
| @ApiModelProperty( value = "Whether the coupon is reusable", readOnly = true ) |
| private boolean reusable; | ||
|
|
||
| @ApiModelProperty( value = "Whether the coupon applies to the license cost only", readOnly = true ) |
gionn
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.