Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

add textures for the guns #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mrowlbio
Copy link

@mrowlbio mrowlbio commented Feb 1, 2020

Added some gun textures

@ClobberXD
Copy link
Owner

Sweet! Will test this within a couple of days.

@ClobberXD
Copy link
Owner

Sorry for the excessive delay in reviewing. I'll try my best to review this today.

@ClobberXD
Copy link
Owner

ClobberXD commented Feb 16, 2020

Checked out the textures, they look pretty good. 64x64 seems a little too detailed though; a resolution of 32x32 might be ideal. Have you given 32x textures a try? Also, horizontally-oriented textures would mean that they wouldn't look straight in game, as MT rotates it by around 45-ish degrees while rendering the wielditem. Have you tested how these look in-game?

@LoneWolfHT
Copy link

LoneWolfHT commented Feb 17, 2020

When/if you do 32x32 try setting the wield scale to 2 x 1.5 x 2 so that the pixels in the wield image are the same size as those of the other wielded items

@mrowlbio
Copy link
Author

mrowlbio commented Feb 19, 2020

Oh, ok I'll try and see if I can make it slanted today but when I had tried earlier it looked bad, I might have to redo them in the slanted orientation. And I did test them in game they looked off but I couldn't tell what, now I know.

@mrowlbio
Copy link
Author

So I rotated the textures and drew over them, but it looks really bad. I was wondering if there is any way in minetest to rotate it without messing it up or will I have to make new textures?

@LoneWolfHT
Copy link

Your definition of 'bad' may be off a bit. Could you push your changes?

@LoneWolfHT
Copy link

Oh, so you just rotated them with your image editor? Might want to just redraw in that case, I don't think you can manage a 45 degree rotation with something that low res without some visual messups

@LoneWolfHT
Copy link

Be a good time to resize to 16x16/32x32 too. If you were planning on doing that

@ClobberXD
Copy link
Owner

<shameless_plug>
On a side-note: Arbitrary rotation is the primary use-case of minetest/minetest#8755, and that would be really useful in this regard.
</shameless_plug>

@skittlemittle
Copy link

they look better unrotated, so maybe when the shameless plug is merged you can use the non rotated textures

@ClobberXD
Copy link
Owner

Yeah, that's what I'm thinking. Horizontal textures always look much cleaner than diagonal textures, IMO.

@mrowlbio
Copy link
Author

I did redraw them just looking at the old ones as a reference.

@mrowlbio
Copy link
Author

And I think 64x is a good size unless it is causing problems

@ClobberXD ClobberXD added the Engine changes required 🚂 Requires changes in MT to be implementable label Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants