Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(pr template) #26

Merged
merged 3 commits into from
Mar 21, 2024
Merged

add(pr template) #26

merged 3 commits into from
Mar 21, 2024

Conversation

ChrOertlin
Copy link
Collaborator

Description

How to test

  • Deploy your janus branch on cg-services-stage - Follow the atlas container documentation.
  • Make sure the newly added functionality works by using the swagger: janus-stage.sys.scilifelab.se
  • Make sure the command cg store qc-metrics can be run to completion on hasta stage.

Implementation Plan

@ChrOertlin ChrOertlin requested a review from a team as a code owner March 19, 2024 11:36
islean
islean approved these changes Mar 19, 2024
View reviewed changes
Copy link

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Might want to add the ###Added, ###Fixed etc if you like that structure.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit 91942c0 into main Mar 21, 2024
3 checks passed
@ChrOertlin ChrOertlin deleted the add-pr-template branch March 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @islean