Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(response by field not alias #23

Merged
merged 5 commits into from
Mar 12, 2024
Merged

fix(response by field not alias #23

merged 5 commits into from
Mar 12, 2024

Conversation

ChrOertlin
Copy link
Collaborator

Description

Let the response model be returned by field values and not alias values.

@ChrOertlin ChrOertlin requested a review from a team as a code owner March 12, 2024 08:35
ivadym
ivadym approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

janus/models/workflow/balsamic.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit 49e3a92 into main Mar 12, 2024
3 checks passed
@ChrOertlin ChrOertlin deleted the response-by-field branch March 12, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivadym ivadym ivadym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @ivadym