Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSES #364] Improve CmButton #365

Merged
merged 5 commits into from
Nov 19, 2023
Merged

[CLOSES #364] Improve CmButton #365

merged 5 commits into from
Nov 19, 2023

Conversation

epixieme
Copy link
Collaborator

Description

Added isLoading prop and conditions for loader and disabling the button

Changes Made

Added isLoading prop set to false and conditions for showing a loader and disabling the button

Screenshots

If applicable, add screenshots to showcase the changes visually.

Checklist

  • I have tested this code.
  • I have updated the documentation.
  • I don't add technical debt with this pr.

Additional Comments

Add any additional comments or notes for reviewers.

@epixieme epixieme linked an issue Nov 16, 2023 that may be closed by this pull request
@epixieme epixieme requested a review from Svenstar74 November 16, 2023 20:31
Copy link

github-actions bot commented Nov 16, 2023

🚀 Expo preview is ready!

  • Project → climate-mind
  • Platforms → android, ios
  • Runtime Version → exposdk:49.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@epixieme epixieme marked this pull request as draft November 17, 2023 06:36
@epixieme
Copy link
Collaborator Author

Tested the solution and it works fine. had to add a smaller Activity loader and take out the margin-top.

@epixieme epixieme marked this pull request as ready for review November 17, 2023 07:34
Copy link
Collaborator

@Svenstar74 Svenstar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 😊 I only made a small change to how the disabled button looks.
Instead of a gray background, I now made the font and the border gray. There are no real requirements from the design team how it should look like anyways, but maybe it looks better^^

@Svenstar74 Svenstar74 changed the title 364 improve cmbutton [CLOSES #364] Improve CmButton Nov 18, 2023
@epixieme epixieme merged commit 9faa81b into main Nov 19, 2023
1 check passed
@epixieme epixieme deleted the 364-improve-cmbutton branch November 19, 2023 18:05
@epixieme epixieme self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CmButton
2 participants