Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cruft code, dependencies #152

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

brews
Copy link
Member

@brews brews commented Dec 10, 2021

Removes unused code, commands from dodola.

More specifically, this removes dodola commands:

  • dodola biascorrect
  • dodola downscale
  • dodola buildweight

Internally, this removes:

  • dodola.core.apply_bias_correction
  • dodola.core.apply_downscaling
  • dodola.core.build_xesmf_weights_file
  • dodola.services.bias_correct
  • dodola.services.downscale
  • dodola.services.build_weights

Relevant tests and external package dependencies (scikit-downscale) are also removed.

close #20
close #82

@brews brews added the enhancement New feature or request label Dec 10, 2021
@brews brews self-assigned this Dec 10, 2021
@brews brews marked this pull request as ready for review December 10, 2021 00:37
@brews brews requested review from dgergel and emileten December 10, 2021 00:37
@brews
Copy link
Member Author

brews commented Dec 10, 2021

For reviews, this is largely a heads-up. Please let me know if I'm removing something critical.

@emileten
Copy link
Contributor

I was wondering whether we were using those at all. Thanks for the cleanup 👍

@brews brews merged commit da7a68b into ClimateImpactLab:main Dec 16, 2021
@brews brews deleted the code_cleanup branch December 16, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants