Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support DBT 1.2 #98

Merged
merged 87 commits into from
Sep 19, 2022
Merged

Updates to support DBT 1.2 #98

merged 87 commits into from
Sep 19, 2022

Conversation

genzgd
Copy link
Contributor

@genzgd genzgd commented Sep 18, 2022

No description provided.

genzgd added 30 commits September 3, 2022 07:57
@genzgd
Materialize checkpoint
a86c2f4
@genzgd
Clean up incremental processing
9a1d0cf
@genzgd
Finish basic grants tests
540ba57
@genzgd
Broke something
f1fa3fe
@genzgd
Failed fix one
6fc74ad
@genzgd
Debugging checkpoint
0822e6d
@genzgd
Fix snapshot quote
d0ba46b
@genzgd
Remove debugging log statements
75d9e3b
@genzgd
Merge branch 'exchange_check' into dbt_1_2
ec4ca83 
# Conflicts:
#	dbt/adapters/clickhouse/impl.py
#	dbt/adapters/clickhouse/relation.py
#	tests/conftest.py
@genzgd
Clean up atomic exchange testing
2b38385
@genzgd
Add dbt 1.2.0 retry connection logic, refactor tests a bit
b26bb67
@genzgd
Expand build workflow
cf7f869
@genzgd
Tweak requirements
298c8f0
@genzgd
Test fixes
e4c11f5
@genzgd
Working on github workflows
3c22202
@genzgd
Working on github workflows
87ecf0c
@genzgd
Working on github workflows
43b1181
@genzgd
Working on github workflows
51612da
@genzgd
Working on github workflows
bf04ee8
@genzgd
Working on github workflows
6fd5110
@genzgd
Working on github workflows
565f2ae
@genzgd
Working on github workflows
a3966d1
@genzgd
Working on github workflows
5ae30bf
@genzgd
Working on github workflows
766c94f
@genzgd
Working on github workflows
53fe872
@genzgd
Working on github workflows
2c6c2ea
@genzgd
Working on github workflows
fd90b68
@genzgd
Working on github workflows
24b56e7
@genzgd
Working on github workflows
cd3e1f1
@genzgd
Working on github workflows
fd3004d
@genzgd
Copy link
Contributor Author

genzgd commented Sep 18, 2022

Note that the cloud tests at this point seem to be failing intermittently because the RBAC functions like GRANT are not synchrous.

Barsoomx
Barsoomx reviewed Sep 19, 2022
View reviewed changes
setup.py Show resolved Hide resolved
mshustov
mshustov reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the cloud tests at this point seem to be failing intermittently because the RBAC functions like GRANT are not synchrous.

How are we going to proceed with it? This PR configured

self._conn_settings['database_replicated_enforce_synchronous_settings'] = '1'
self._conn_settings['insert_quorum'] = '2'

If it doesn't help, we need to find a workaround or skip Cloud tests until we address the problem.

dbt/adapters/clickhouse/credentials.py Show resolved Hide resolved
dbt/adapters/clickhouse/credentials.py Outdated Show resolved Hide resolved
dbt/adapters/clickhouse/connections.py Show resolved Hide resolved
@genzgd genzgd merged commit a94c5fd into master Sep 19, 2022
@mshustov mshustov deleted the dbt_1_2_cloud branch September 20, 2022 07:12
@mshustov mshustov mentioned this pull request Sep 20, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov left review comments

@Barsoomx Barsoomx Barsoomx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genzgd @mshustov @Barsoomx