Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow adding an empty seed without rows #341

Merged
merged 1 commit into from
Aug 18, 2024
Merged

feat: allow adding an empty seed without rows #341

merged 1 commit into from
Aug 18, 2024

Conversation

igorvoltaic
Copy link
Contributor

@igorvoltaic igorvoltaic commented Aug 18, 2024 •
edited
Loading

Summary

Fixes #330: allow inserting an empty seed with column names only (in fact create table and do not insert anything)

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@mshustov mshustov requested a review from BentsiLeviav August 18, 2024 09:25
@BentsiLeviav BentsiLeviav merged commit 1ad813c into ClickHouse:main Aug 18, 2024
21 checks passed
@igorvoltaic igorvoltaic deleted the add-empty-seed branch August 19, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentsiLeviav BentsiLeviav BentsiLeviav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inserting single row seed with column names only fails
2 participants
@igorvoltaic @BentsiLeviav