Skip to content

Commit

Permalink
Skip order columns if engine Distributed #14
Browse files Browse the repository at this point in the history
  • Loading branch information
silentsokolov authored Feb 6, 2022
1 parent 63b5433 commit d1d09e7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions dbt/include/clickhouse/macros/adapters.sql
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

{% macro order_cols(label) %}
{%- set cols = config.get('order_by', validator=validation.any[list, basestring]) -%}
{%- set engine = config.get('engine', validator=validation.any[basestring]) -%}
{%- if cols is not none %}
{%- if cols is string -%}
{%- set cols = [cols] -%}
Expand All @@ -34,6 +35,7 @@
{%- if not loop.last -%},{%- endif -%}
{%- endfor -%}
)
{%- elif engine.startswith('Distributed') %}
{%- else %}
{{ label }} (tuple())
{%- endif %}
Expand Down

3 comments on commit d1d09e7

@emirkmo
Copy link

@emirkmo emirkmo commented on d1d09e7 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this commit?

@genzgd
Copy link
Contributor

@genzgd genzgd commented on d1d09e7 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of a PR that remains open and incomplete?

@genzgd
Copy link
Contributor

@genzgd genzgd commented on d1d09e7 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was closed by the original contributor and never merged. CLA was also never signed.

Please sign in to comment.