Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom url path #948

Closed
wants to merge 2 commits into from

Conversation

radmirnovii
Copy link

Motivation:
Useful with http proxy. Previous version in ru.yandex.clickhouse has this feature with option USE_PATH_AS_DB=false.

current driver has WEB_CONTEXT option but it used only with trailing slash

@zhicwu
Copy link
Contributor

zhicwu commented Jun 3, 2022

Thank you @radmirnovii. Can we reuse web_context? I'm testing connection string with multiple hosts/URIs. Perhaps we can enhance the option to support both cases.

@radmirnovii
Copy link
Author

Can we reuse web_context?
Do you want to just remove adding trailing slash in path?

@zhicwu
Copy link
Contributor

zhicwu commented Jun 7, 2022

Do you want to just remove adding trailing slash in path?

Yes. Web context should be also considered for health check like ping, because the url will be changed to http://host:port/<web_context>/ping. What's your scenario? I didn't see unit test there, so my guess was just arbitrary path without query or fragment, right?

Apologize for holding your PR for so long, I'll merge the 2 PRs with minor changes maybe, once I got load balancing performance issue fixed :<

@zhicwu
Copy link
Contributor

zhicwu commented Jun 20, 2022

Fixed in #956 along with some more tests.

@zhicwu zhicwu closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants