Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant data transfer timeout property #703

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

kaifeur
Copy link

@kaifeur kaifeur commented Aug 16, 2021

dataTransferTimeout property was only used to set max_execution_time as a sum of socket_timeout and dataTransferTimeout. From 6851fd7 behavior changed: max_execution_time is set as max_execution_time, has nothing to do with socket or data transfer timeouts.

(and also there are some misleading old docs about it)

@github-actions
Copy link

Benchmark                           (client)  (connection)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20   226.359 ±  45.440  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20   223.088 ±  28.855  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20   223.884 ±  36.218  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20   253.696 ±  31.697  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse       normal  thrpt   20  1221.593 ± 171.877  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc         reuse     prepared  thrpt   20  1263.176 ± 181.028  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new       normal  thrpt   20  1278.258 ± 166.768  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc           new     prepared  thrpt   20  1063.829 ± 175.259  ops/s

@zhicwu zhicwu merged commit 6729d5a into ClickHouse:develop Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants