Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when initializing connection #685

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Fix NPE when initializing connection #685

merged 2 commits into from
Jul 11, 2021

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Jul 11, 2021

Closes #683

@zhicwu zhicwu linked an issue Jul 11, 2021 that may be closed by this pull request
Got NPE inside ClickHouseResultSet.toString when LogProxy is enabled #683
Closed
@github-actions
Copy link 

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   263.084 ±  30.319  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   254.686 ±  28.209  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1279.075 ± 155.544  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1193.304 ± 164.261  ops/s

@github-actions
Copy link 

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   255.661 ±  27.035  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   248.946 ±  28.692  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1491.913 ± 174.873  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1387.758 ± 209.374  ops/s

@zhicwu zhicwu merged commit 0f20121 into ClickHouse:develop Jul 11, 2021
@zhicwu zhicwu deleted the fix-npe branch July 11, 2021 08:49
@zhicwu zhicwu mentioned this pull request Jul 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Got NPE inside ClickHouseResultSet.toString when LogProxy is enabled
1 participant
@zhicwu