Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Fix Bitmap SerDe #1876

Merged
merged 4 commits into from
Oct 29, 2024
Merged

[client-v2] Fix Bitmap SerDe #1876

merged 4 commits into from
Oct 29, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Oct 21, 2024

Summary

There is a problem in Bitmap deserialization because of missing check for end of the stream in one of code branches.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser marked this pull request as ready for review October 23, 2024 18:21
@mzitnik
Copy link
Contributor

mzitnik commented Oct 28, 2024

@chernser, can you explain exactly what was fixed? (do we have a issue ti describe?)

@chernser
Copy link
Contributor Author

@mzitnik I've updated the PR description.

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
68.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser merged commit ec9f249 into main Oct 29, 2024
58 of 60 checks passed
@chernser chernser deleted the v2_fix_aggregate_function_serde branch October 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants