Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Async Configuration #1767

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[client-v2] Async Configuration #1767

merged 3 commits into from
Aug 15, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Aug 10, 2024

Summary

Async execution doesn't help much if done inside the client. Application usually has better understanding how to organize threads. Handling async code is more complex and hides some issues.

What will be changed:

  • async configuration applied to a client v2. By default request will be executed in the same thread.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser changed the title [client-v2] async configuration & reader factory method [client-v2] Async Configuration Aug 13, 2024
@chernser chernser marked this pull request as ready for review August 13, 2024 21:10
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser requested a review from mzitnik August 14, 2024 17:33
@chernser chernser merged commit 0268b89 into main Aug 15, 2024
65 of 66 checks passed
@chernser chernser deleted the small_api_fixes01 branch August 15, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants