Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Https Support #1753

Merged
merged 8 commits into from
Jul 31, 2024
Merged

[client-v2] Https Support #1753

merged 8 commits into from
Jul 31, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Jul 30, 2024 •
edited
Loading

Summary

Closes #1715

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
40.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@chernser chernser merged commit 9e53b41 into main Jul 31, 2024
60 of 61 checks passed
@chernser chernser deleted the feat_support_https branch July 31, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] mTLS & HTTPs support
2 participants
@chernser @Paultagoras