Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in addEndpoint detection of SSL from URL string #1719

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add in addEndpoint detection of SSL from URL string #1719

merged 1 commit into from
Jul 3, 2024

Conversation

mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Jul 3, 2024

Summary

Add in addEndpoint detection of SSL from URL string

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@mzitnik mzitnik requested review from chernser and Paultagoras July 3, 2024 06:10
@chernser chernser merged commit 247f322 into main Jul 3, 2024
58 checks passed
@chernser chernser deleted the fix_endpoint_ssl_detect branch July 3, 2024 06:21
@chernser chernser linked an issue Jul 7, 2024 that may be closed by this pull request
[client-v2] addEndpoint(String) doesn't enable https protocol #1718
Closed
@chernser chernser added this to the 0.6.3 Release milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chernser chernser chernser approved these changes

@Paultagoras Paultagoras Awaiting requested review from Paultagoras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.3 Release
Development

Successfully merging this pull request may close these issues.

[client-v2] addEndpoint(String) doesn't enable https protocol
2 participants
@mzitnik @chernser