Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reflect for plain arrays #1121

Closed
wants to merge 7 commits into from

Conversation

cergxx
Copy link
Contributor

@cergxx cergxx commented Oct 17, 2023

draft proof of concept for #1122

@jkaflik
Copy link
Contributor

jkaflik commented Oct 23, 2023

@cergxx would you like to continue on this PR?

@cergxx
Copy link
Contributor Author

cergxx commented Oct 23, 2023

@cergxx would you like to continue on this PR?

Yes, if you approve this approach.
As I see it now, I need to add the missing types to appendRowFast() and polish the code (better naming, comments etc)

@jkaflik
Copy link
Contributor

jkaflik commented Oct 24, 2023

@cergxx I am totally fine with such an approach. Please let me know if you need anything from me.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cergxx
❌ Sergey Salnikov


Sergey Salnikov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cergxx cergxx closed this Oct 24, 2023
@cergxx
Copy link
Contributor Author

cergxx commented Oct 24, 2023

Recreated in #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants