Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeBufOnConnRelease to clickhouse.Options #1091

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add FreeBufOnConnRelease to clickhouse.Options #1091

merged 1 commit into from
Sep 12, 2023

Conversation

cergxx
Copy link
Contributor

@cergxx cergxx commented Sep 8, 2023

Summary

Add a flag to clickhouse.Options which will trigger connection's buffer being dropped on query execution finish
Resolves issue #1086

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jkaflik
jkaflik approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkaflik jkaflik merged commit 7b3567b into ClickHouse:main Sep 12, 2023
5 of 13 checks passed
@cergxx cergxx deleted the drop-buffer-on-conn-release-1086 branch September 13, 2023 20:38
@cergxx cergxx mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cergxx @CLAassistant @jkaflik