Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup examples/std/compression.go #1036

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Cleanup examples/std/compression.go #1036

merged 8 commits into from
Oct 26, 2023

Conversation

cxiang03
Copy link
Contributor

Summary

Chores Example Codes Improve

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jkaflik
Copy link
Contributor

jkaflik commented Aug 2, 2023

Thanks @cxiang03 . This will go with the next minor release.

@jkaflik jkaflik self-requested a review August 2, 2023 12:36
jkaflik
jkaflik requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this introduces a bug

examples/std/compression.go Outdated Show resolved Hide resolved
@jkaflik jkaflik added stale requires a follow-up and removed release-candidate labels Aug 10, 2023
@cxiang03
Copy link
Contributor Author

this introduces a bug

🫣 applied

cxiang03
cxiang03 commented Aug 10, 2023
View reviewed changes
examples/std/compression.go Outdated Show resolved Hide resolved
@jkaflik jkaflik changed the title chores clean up Cleanup examples/std/compression.go Oct 26, 2023
@jkaflik jkaflik merged commit 3d3d8b3 into ClickHouse:main Oct 26, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
stale requires a follow-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cxiang03 @CLAassistant @jkaflik