Remove test coverage for deprecated Object('JSON') type (#1377)

* Remove test coverage for deprecated Object('JSON') type

ClickHouse has deprecated support for (https://clickhouse.com/docs/en/sql-reference/data-types/object-data-type. Object('JSON') has been aliased with JSON for a long time in ClickHouse as an experimental type. It's replaced by a new JSON type: https://clickhouse.com/docs/en/sql-reference/data-types/newjson (still experimental)

clickhouse-go implements support for Object('JSON'), but not for a new JSON type. To avoid confusion, all test coverage and mentions are removed for the deprecated type.

New JSON type support needs to be implemented in clickhouse-go.

* Add JSON column implementation comment

* Remove function calls

examples/clickhouse_api/main_test.go

@@ -59,11 +59,6 @@ func TestMain(m *testing.M) {
 
 // ClickHouse API tests
 
-func TestJSON(t *testing.T) {
-	require.NoError(t, InsertReadJSON())
-	require.NoError(t, ReadComplexJSON())
-}
-
 func TestOpenTelemetry(t *testing.T) {
 	require.NoError(t, OpenTelemetry())
 }

examples/std/main_test.go

@@ -112,10 +112,6 @@ func TestStdMapInsertRead(t *testing.T) {
 	require.NoError(t, MapInsertRead())
 }
 
-func TestStdJSON(t *testing.T) {
-	require.NoError(t, JSONInsertRead())
-}
-
 func TestStdCompression(t *testing.T) {
 	require.NoError(t, CompressOpenDB())
 	require.NoError(t, CompressOpen())

lib/column/json.go

@@ -19,12 +19,22 @@ package column
 
 import (
 	"fmt"
-	"github.com/ClickHouse/ch-go/proto"
 	"reflect"
 	"strings"
 	"time"
+
+	"github.com/ClickHouse/ch-go/proto"
 )
 
+// This JSON type implementation was done for an experimental Object('JSON') type:
+// https://clickhouse.com/docs/en/sql-reference/data-types/object-data-type
+// It's already deprecated in ClickHouse and will be removed in the future.
+// Since ClickHouse 24.8, the Object('JSON') type is no longer alias for JSON type.
+// The new JSON type has been introduced: https://clickhouse.com/docs/en/sql-reference/data-types/newjson
+// However, the new JSON type is not supported by the driver yet.
+//
+// This implementation is kept for backward compatibility and will be removed in the future. TODO: remove this
+
 // inverse mapping - go types to clickhouse types
 var kindMappings = map[reflect.Kind]string{
 	reflect.String:  "String",

tests/issues/1072_test.go

@@ -10,7 +10,8 @@ import (
 )
 
 func Test1072(t *testing.T) {
-	clickhouse_tests.SkipOnCloud(t, "The JSON data type is an obsolete feature on Cloud.")
+	t.Skip("Object JSON type is deprecated. Test is kept for a historical reference.")
+
 	var (
 		conn, err = clickhouse_tests.GetConnection("issues", clickhouse.Settings{
 			"max_execution_time":             60,

tests/issues/1113_test.go

@@ -10,7 +10,8 @@ import (
 )
 
 func Test1113(t *testing.T) {
-	clickhouse_tests.SkipOnCloud(t, "The JSON data type is an obsolete feature on Cloud.")
+	t.Skip("Object JSON type is deprecated. Test is kept for a historical reference.")
+
 	var (
 		conn, err = clickhouse_tests.GetConnection("issues", clickhouse.Settings{
 			"max_execution_time":             60,

tests/issues/1119_test.go

@@ -10,7 +10,8 @@ import (
 )
 
 func Test1119(t *testing.T) {
-	clickhouse_tests.SkipOnCloud(t, "The JSON data type is an obsolete feature on Cloud.")
+	t.Skip("Object JSON type is deprecated. Test is kept for a historical reference.")
+
 	var (
 		conn, err = clickhouse_tests.GetConnection("issues", clickhouse.Settings{
 			"max_execution_time":             60,