Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update host resolver a little bit often #71863

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

CheSema
Copy link
Member

@CheSema CheSema commented Nov 13, 2024

It was my intention from the start to update HostResolver a little bit often that history period.
It just my miss that we update HostResolver once in history period.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Update HostResolver 3 times in a history period.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label Nov 13, 2024
@davenger davenger self-assigned this Nov 13, 2024
@@ -202,8 +203,10 @@ bool HostResolver::isUpdateNeeded()
{
Poco::Timestamp now;

auto piece_history = Poco::Timespan(history.totalMicroseconds() / 3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think resolve_interval would be a better name

@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Nov 13, 2024

This is an automated comment for commit e5e95b8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CheSema
Copy link
Member Author

CheSema commented Nov 14, 2024

test_storage_mongodb/test.py::test_secure_connection_uri -- flaks in master with
DB::Exception: mongocxx::v_noabi::query_exception: Authentication failed.: generic server error

stats

@CheSema
Copy link
Member Author

CheSema commented Nov 14, 2024

Stateless asan 03006_parallel_replicas_prewhere -- #71919

@CheSema CheSema added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 92c4dcf Nov 14, 2024
211 of 217 checks passed
@CheSema CheSema deleted the chesema_update_hostresolver branch November 14, 2024 13:55
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 14, 2024
@CheSema CheSema added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 14, 2024
robot-ch-test-poll4 added a commit that referenced this pull request Nov 14, 2024
Cherry pick #71863 to 24.8: update host resolver a little bit often
robot-ch-test-poll4 added a commit that referenced this pull request Nov 14, 2024
Cherry pick #71863 to 24.9: update host resolver a little bit often
robot-ch-test-poll4 added a commit that referenced this pull request Nov 14, 2024
Cherry pick #71863 to 24.10: update host resolver a little bit often
robot-clickhouse added a commit that referenced this pull request Nov 14, 2024
Backport #71863 to 24.9: update host resolver a little bit often
CheSema added a commit that referenced this pull request Nov 15, 2024
Backport #71863 to 24.8: update host resolver a little bit often
CheSema added a commit that referenced this pull request Nov 15, 2024
Backport #71863 to 24.10: update host resolver a little bit often
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants