-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update host resolver a little bit often #71863
Conversation
src/Common/HostResolvePool.cpp
Outdated
@@ -202,8 +203,10 @@ bool HostResolver::isUpdateNeeded() | |||
{ | |||
Poco::Timestamp now; | |||
|
|||
auto piece_history = Poco::Timespan(history.totalMicroseconds() / 3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think resolve_interval
would be a better name
This is an automated comment for commit e5e95b8 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
test_storage_mongodb/test.py::test_secure_connection_uri -- flaks in master with |
Stateless asan 03006_parallel_replicas_prewhere -- #71919 |
Cherry pick #71863 to 24.8: update host resolver a little bit often
Cherry pick #71863 to 24.9: update host resolver a little bit often
Cherry pick #71863 to 24.10: update host resolver a little bit often
Backport #71863 to 24.9: update host resolver a little bit often
Backport #71863 to 24.8: update host resolver a little bit often
Backport #71863 to 24.10: update host resolver a little bit often
It was my intention from the start to update HostResolver a little bit often that
history
period.It just my miss that we update HostResolver once in
history
period.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Update
HostResolver
3 times in ahistory
period.Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):