Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle c-ares 3rd-party library #41239

Merged
merged 5 commits into from
Sep 16, 2022
Merged

Bundle c-ares 3rd-party library #41239

merged 5 commits into from
Sep 16, 2022

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Sep 12, 2022

See #35630 and #37827 (comment)

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The c-ares library is now bundled with ClickHouse's build system

@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Sep 12, 2022
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-build Pull request with build/testing/packaging improvement label Sep 12, 2022
@rschu1ze rschu1ze changed the title [WIP] Bundled c-ares Bundle c-ares Sep 12, 2022
@rschu1ze
Copy link
Member Author

@arthurpassos FYI

@rschu1ze rschu1ze marked this pull request as ready for review September 12, 2022 20:44
@rschu1ze rschu1ze changed the title Bundle c-ares Bundle 3rd-party library "c-ares" Sep 13, 2022
@rschu1ze rschu1ze changed the title Bundle 3rd-party library "c-ares" Bundle c-ares 3rd-party library Sep 13, 2022
@antonio2368 antonio2368 self-assigned this Sep 15, 2022
@rschu1ze
Copy link
Member Author

Merci for approving :)

@rschu1ze rschu1ze merged commit 545893f into master Sep 16, 2022
@rschu1ze rschu1ze deleted the bundled-c-ares branch September 16, 2022 10:06
yokofly added a commit to timeplus-io/proton that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants