WriteBufferFromS3 potential deadlock fix #40070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitaisreal
commented
Aug 10, 2022
src/IO/WriteBufferFromS3.cpp
Outdated
| @@ -272,7 +285,7 @@ void WriteBufferFromS3::writePart() | |||
| file_segments_holder.reset(); | |||
| } | |||
|
|
|||
| schedule([this, task]() | |||
| schedule([this, task, task_notify]() | |||
There was a problem hiding this comment.
Schedule can throw exception, in that case we could miss notify event.
robot-clickhouse
added
the
pr-not-for-changelog
kitaisreal
force-pushed
the
write-buffer-from-s3-potential-deadlock-fix
branch
from
e1b56c1 to
fa65769
Compare
KochetovNicolai
approved these changes
Aug 10, 2022
kitaisreal
force-pushed
the
write-buffer-from-s3-potential-deadlock-fix
branch
from
fa65769 to
4b1c93d
Compare
|
@KochetovNicolai Changelog should be edited. |
kitaisreal
added
the
can be tested
|
@kitaisreal please check if it fixes #38158. |
kitaisreal
force-pushed
the
write-buffer-from-s3-potential-deadlock-fix
branch
from
6c7576c to
60e4010
Compare
kitaisreal
force-pushed
the
write-buffer-from-s3-potential-deadlock-fix
branch
from
60e4010 to
ee5e61c
Compare
kitaisreal
added
bug
robot-clickhouse
added
the
pr-bugfix
tavplubix
removed
the
bug
kitaisreal
added
the
pr-must-backport
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 23, 2022
kitaisreal
added a commit
that referenced
this pull request
Aug 24, 2022
Backport #40070 to 22.7: WriteBufferFromS3 potential deadlock fix
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 1, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 1, 2022
robot-ch-test-poll
added
the
pr-backports-created
kitaisreal
added a commit
that referenced
this pull request
Sep 8, 2022
Backport #40070 to 22.6: WriteBufferFromS3 potential deadlock fix
kitaisreal
added a commit
that referenced
this pull request
Sep 8, 2022
Backport #40070 to 22.3: WriteBufferFromS3 potential deadlock fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix potential deadlock in WriteBufferFromS3 during task scheduling failure.