Order by tuple #38873
Merged
Order by tuple #38873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-not-for-changelog
devcrafter
added
bug
devcrafter
force-pushed
the
order_by_with_braces
branch
from
39e48bb to
c7f9945
Compare
robot-clickhouse
added
pr-bugfix
devcrafter
force-pushed
the
order_by_with_braces
branch
from
c7f9945 to
8f51f1f
Compare
devcrafter
removed
the
bug
- remove unnecessary code for this PR
alexey-milovidov
added
pr-performance
devcrafter
force-pushed
the
order_by_with_braces
branch
from
8f51f1f to
a0f6f6f
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
yakov-olkhovskiy
approved these changes
Jul 6, 2022
|
BTW this optimization makes WITH FILL works for such case 👍 |
I didn't think about it. Thanks for mentioning it. I'd like to add a test before merge it |
|
@Mergifyio update |
❌ Base branch update has failedmerge conflict between base and head |
- complexity comes from dreaming about EXPLAIN queries as an ordinary ones returning scalar result. So they can be used in SQL tests instead of shell ones
novikd
reviewed
Apr 3, 2024
| # check that both queries have the same AST after rewrite, EXPLAIN SYNTAX returns it in form of query | ||
| ################## | ||
| QUERY_ORDER_BY="SELECT number AS a, number % 2 AS b FROM numbers(10) ORDER BY a DESC NULLS FIRST WITH FILL FROM 2 TO 1 STEP -1, b DESC NULLS FIRST WITH FILL FROM 2 TO 1 STEP -1" | ||
| QUERY_ORDER_BY_TUPLE="SELECT number AS a, number % 2 AS b FROM numbers(10) ORDER BY (a, b) DESC NULLS FIRST WITH FILL FROM 2 TO 1 STEP -1" |
There was a problem hiding this comment.
@devcrafter I'm not sure if we can do such an optimization. Is the query without optimization and with this WITH FILL valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #38772
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
A less efficient execution plan can be generated for query with ORDER BY (a, b) than for ORDER BY a, b