Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnaryLogicalFunctions improve performance using dynamic dispatch #38058

Conversation

kitaisreal
Copy link
Contributor

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Improve performance of not function using dynamic dispatch.

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Jun 14, 2022
@qoega qoega added the can be tested Allows running workflows for external contributors label Jun 14, 2022
@kitaisreal kitaisreal self-assigned this Jun 14, 2022
@alexey-milovidov alexey-milovidov self-assigned this Jun 15, 2022
@alexey-milovidov alexey-milovidov merged commit 04e25bc into ClickHouse:master Jun 15, 2022
@Alex-Cheng
Copy link
Contributor

I feel that the optimization is leveraging that compiler can decide something on compile time instead of decide something on run-time. It sounds to be "not using dynamic dispatch" because dynamic dispatch is related to "making decision on run-time" something like virtual function table.

@alexey-milovidov
Copy link
Member

@Alex-Cheng This is dynamic dispatch - the instruction set is selected in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants