Add feature disks (ls, C, list-disks, disk, help) #36060

Varinara · 2022-04-08T09:35:04Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add feature disks(
ls - list files on disk,
C - set config file,
list-disks - list disks names,
disk - set disk for work by name,
help - produce help message
copy - copy data on disk containing at from_path to to_path
link - Create hardlink on disk from from_path to to_path
list - List files on disk
move - Move file or directory on disk from from_path to to_path
read - read File on disk from_path to to_path or to stdout
remove - Remove file or directory on disk with all children.
write - Write File on diskfrom_path or stdin to to_path)

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

GrigoryPervakov · 2022-04-08T10:43:11Z

src/Interpreters/Context.h

@@ -844,6 +844,9 @@ class Context: public std::enable_shared_from_this<Context>

    void shutdown();

+    std::vector<std::string> listDisks();
+    void listFiles(const String & name, const String & path, std::vector<String> & file_names);


You can get disk instance in your calling method, I think this method should be part of the disks tool, not context.

GrigoryPervakov · 2022-04-08T10:45:36Z

src/Interpreters/Context.cpp

+    std::vector<std::string> disksNames;
+    std::lock_guard lock(shared->storage_policies_mutex);
+
+    for (auto & [disk_name, disk] : getDiskSelector(lock)->getDisksMap())


getDiskSelector is a part of public interface of the context. You can do it inside disks tool code.

Varinara · 2022-04-08T11:02:02Z

The tests will be written later, now you can look at it

ianton-ru · 2022-04-15T10:36:55Z

programs/disks/Path.h

@@ -0,0 +1,29 @@
+#ifndef CLICKHOUSE_PATH_H
+#define CLICKHOUSE_PATH_H


'#pragma once' is enough.

ianton-ru · 2022-04-15T10:48:08Z

programs/disks/disks.cpp

+            std::cout << *it << "\n";
+        }
+    }
+    else


Bad codestyle. Try to use clang-format with 'IndentWidth: 4'.

ianton-ru · 2022-04-15T10:48:41Z

programs/disks/disks.cpp

+        run();
+    }
+    else
+        if (curCommand == "ls")


ianton-ru · 2022-04-15T10:56:26Z

programs/disks/disks.cpp

+{
+    if (curCommand == "start")
+    {
+        if (int(argumentsToDo.size()) == 1)


Do not use c-style type casts, read https://clickhouse.com/docs/ru/development/style/

And cast from size_t (64 bit) to int (32 bit) is a very dangerous. int(0x100000001ULL) == 1

ianton-ru · 2022-04-15T11:01:42Z

programs/disks/disks.cpp

+
+            disk_test->listFiles(full_path, file_names);
+
+            for (auto iter = file_names.begin(); iter != file_names.end(); iter++)


C++11 style for (const auto &file_name : file_names) is more readable.

ianton-ru · 2022-04-15T11:08:59Z

programs/disks/disks.cpp

+void DisksFunc::initialize(Poco::Util::Application & self)
+{
+    Poco::Util::Application::initialize(self);
+    if (curCommand == "start")


You use string iterals for command ("start", "ls", etc.) in multiple places. Move it into constants.

ianton-ru · 2022-04-15T11:13:24Z

programs/disks/disks.cpp

+
+void DisksFunc::init(std::vector<String> &common_arguments)
+{
+    namespace po = boost::program_options;


This alias used in several methods, move it to top of the file.

ianton-ru · 2022-04-15T11:14:07Z

programs/disks/disks.cpp

+    if (curCommand == "start")
+        helpOptionDescription.emplace(createOptionsDescription("Help Message", getTerminalWidth()));
+
+    boost::program_options::positional_options_description positional_options_description;


If you use namespace alias, use it everywhere.

ianton-ru · 2022-04-15T11:18:57Z

programs/disks/disks.h

+    Path diskPath = Path();
+    Arguments argumentsToDo;
+
+    std::map<String, bool> fArgOpt;


Codestyle, use snake_case for variables.

GrigoryPervakov · 2022-04-15T12:34:12Z

programs/disks/Path.cpp

+    diskName = "default";
+}
+
+void Path::parsPath(std::string toPars)


It should be parsePath?

GrigoryPervakov · 2022-04-15T12:35:17Z

programs/disks/Path.h

+struct Path
+{
+public:
+    Path();


Default disk name could be overriden via glob option, so you can pass it here

GrigoryPervakov · 2022-04-15T12:36:44Z

programs/disks/Path.h

+    Path();
+
+    void parsPath(std::string toPars);
+    void setDiskName(std::string name);


If you pass default disk name(or overriden via args) this method is useless
And probably you can pass path to parse in constructor too

GrigoryPervakov · 2022-04-15T12:38:13Z

programs/disks/disks.h

+
+namespace ErrorCodes
+{
+    extern const int NOT_IMPLEMENTED;


Couldn't find usages of it

GrigoryPervakov · 2022-04-15T12:39:18Z

programs/disks/disks.h

+    extern const int NOT_IMPLEMENTED;
+}
+
+class DisksFunc : public Poco::Util::Application


May be DIsksTool or DisksApp can more obviously describe purpose of this class

GrigoryPervakov · 2022-04-15T12:41:20Z

programs/disks/disks.cpp

+        }
+}
+
+void DisksFunc::reloadConfiguration()


This method is called only once on initializtion, so it's better loadCondfiguration, but I think you can just inline it in caller

GrigoryPervakov · 2022-04-15T12:45:01Z

programs/disks/disks.cpp

+
+void DisksFunc::printHelpMessage()
+{
+    if (curCommand == "start")


Maybe we should build special command description object, that contains all info about command:

name

method to call

program options

base help message
So you can generate help message in generic way here based only on that information.
It would simplify adding new commands. You can introduce new command by adding new item in commands map instead of searching a lot of methods where you should put new if statement

GrigoryPervakov · 2022-04-15T12:58:30Z

programs/disks/disks.cpp

+void DisksFunc::listDisks()
+{
+    while(argumentsToDo[0] != "list-disks")
+        argumentsToDo.erase(argumentsToDo.begin());


This code duplicates same for ls and would be for all other commands, it can be easily generalized in code before actual command call

GrigoryPervakov · 2022-04-21T11:09:01Z

programs/disks/Path.cpp

+    path = "";
+    disk_name = def_disk_name;
+
+    if (to_parse.find(':') == std::string::npos)


if(auto pr = to_parse.find(':'); pr == std::string::npos)
You can avoid second find call

kssenii · 2022-04-24T16:16:06Z

programs/disks/Path.cpp

+
+Path::Path(std::string def_disk_name, std::string to_parse)
+{
+    path = "";


this line is redundant

kssenii · 2022-04-24T16:34:07Z

programs/disks/disks.cpp

+    std::cout << cur_command_description.command_name<<'\n';
+    std::cout << cur_command_description.description<<'\n';
+    std::cout << cur_command_description.usage<<'\n';


Suggested change

std::cout << cur_command_description.command_name<<'\n';

std::cout << cur_command_description.description<<'\n';

std::cout << cur_command_description.usage<<'\n';

std::cout << cur_command_description.command_name << '\n';

std::cout << cur_command_description.description << '\n';

std::cout << cur_command_description.usage << '\n';

kssenii · 2022-04-24T16:35:49Z

programs/disks/disks.cpp

+    comand_descriptions.emplace("ls", DB::CommandDescription{
+        .command_name = "ls",
+        .command_option_description = createOptionsDescription("Help Message for ls", getTerminalWidth()),
+        .description = "List FILEs (the default disk by default)",


Suggested change

.description = "List FILEs (the default disk by default)",

.description = "List files (the default disk is used by default)",

kssenii · 2022-04-24T16:39:21Z

programs/disks/disks.h

+    ContextMutablePtr global_context;
+    SharedContextHolder shared_context;
+
+    std::vector<String> in;


in -- bad name. Better something like command_arguments.

kssenii · 2022-04-24T16:53:47Z

programs/disks/disks.cpp

+std::optional<String> DisksApp::FindPosArg(Arguments & arguments)
+{
+    for (const auto &pos_arg : arguments)
+        if (f_arg_pos[pos_arg])
+            return {pos_arg};
+    return {};
+}


The position of the command (ls, etc) is known and always the same. So it is better to just check if the command is supported by checking it in a set

static const std::unordered_set<std::string_view> supported_commands = {"ls", ...};

kssenii · 2022-04-24T16:56:16Z

programs/disks/disks.cpp

+    global_context->makeGlobalContext();
+    global_context->setApplicationType(Context::ApplicationType::DISKS);
+
+    (this->*positional_arg_map[in[0]])();


Let's remove this std::map<String, void (DisksApp::*)() > positional_arg_map;.
And use a simple if instead. Here optimization is not important while readablity of code is.

Or put it inside the CommandDescription

kssenii · 2022-05-08T10:13:20Z

tests/integration/test_disks_app_func/test.py

+        cluster.add_instance(
+            "disks_test",
+            main_configs=["config.xml"],
+            with_zookeeper=True,


line 16 -- probably redundant

kssenii · 2022-05-08T10:16:50Z

tests/integration/test_disks_app_func/config.xml

+        <source_trivial_cluster>
+            <shard>
+                <replica>
+                    <host>disks_test</host>


remote_servers config also redundant, it is not necessary for instance name to be defined here.

kssenii · 2022-05-08T10:23:02Z

tests/integration/test_disks_app_func/test.py

+    ]
+
+    instance = started_cluster.instances["disks_test"]
+    container = instance.get_docker_handle()


you could also use exec_in_container function from helpers/cluster as it will look simpler

ClickHouse/tests/integration/helpers/cluster.py

Lines 3122 to 3125 in fac59df

def exec_in_container(self, cmd, detach=False, nothrow=False, **kwargs):

return self.cluster.exec_in_container(

self.docker_id, cmd, detach, nothrow, **kwargs

)

but current way is also ok.

kssenii · 2022-05-08T10:25:13Z

programs/CMakeLists.txt

@@ -55,6 +55,8 @@ option (ENABLE_CLICKHOUSE_KEEPER "ClickHouse alternative to ZooKeeper" ${ENABLE_

 option (ENABLE_CLICKHOUSE_KEEPER_CONVERTER "Util allows to convert ZooKeeper logs and snapshots into clickhouse-keeper snapshot" ${ENABLE_CLICKHOUSE_ALL})

+option (ENABLE_CLICKHOUSE_DISKS "Work with disks" ${ENABLE_CLICKHOUSE_ALL})


Suggested change

option (ENABLE_CLICKHOUSE_DISKS "Work with disks" ${ENABLE_CLICKHOUSE_ALL})

option (ENABLE_CLICKHOUSE_DISKS "A tool to manage disks" ${ENABLE_CLICKHOUSE_ALL})

something like this, or more informative.

kssenii · 2022-05-08T10:34:09Z

programs/disks/Path.h

+
+private:
+    std::string path;
+    std::string disk_name;


This struct is quite simple, so may be do just like this without any getters:

struct Path { std:string disk_name; std::string path; Path(const std::string & disk_name_, const String & path_) : disk_name(disk_name), path(path_) {} };

Getters are usually better for something not as simple.

kssenii · 2022-05-08T10:39:45Z

programs/disks/disks.cpp

+
+    global_context->makeGlobalContext();
+    global_context->setApplicationType(Context::ApplicationType::DISKS);
+    global_context->setPath(PATH);


path should not be hardcoded here to PATH, need to get it from config.

kssenii · 2022-05-08T10:50:13Z

programs/disks/disks.cpp

+
+    disk->listFiles(full_path, file_names);
+
+    for (const auto &file_name : file_names)


Suggested change

for (const auto &file_name : file_names)

for (const auto & file_name : file_names)

kssenii · 2022-05-08T10:59:55Z

programs/disks/disks.cpp

+    {
+        String out;
+        auto in = disk->readFile(full_path);
+        readStringUntilEOF(out, *in);


It might not fill into memory. Try to use WriteBufferFromFileDescriptor and copyData.

kssenii · 2022-05-08T11:02:26Z

programs/disks/disks.cpp

+        String full_path_input = disk->getPath();
+        full_path_input.pop_back();
+        full_path_input += config().getString("input");


Suggested change

String full_path_input = disk->getPath();

full_path_input.pop_back();

full_path_input += config().getString("input");

String full_path_input = std::filesystem::path(disk->getPath()) / config().getString("input");

kssenii · 2022-05-08T11:34:59Z

programs/disks/disks.h

+    std::optional<ProgramOptionsDescription> command_option_description;
+    String description;
+    String usage;
+    void (DisksApp::*arg_func)(void);


Let's get rid of void (DisksApp::*arg_func)(void);.
You can just make a class for each command, with inheritance from ICommand and using command_descriptions = std::unordered_map<std:string, CommandPtr>, where CommandPtr=std::shared_ptr<ICommand>. Each will override virtual methods execute(), validateArguements(...), getHelpMessage(), ...

ianton-ru · 2022-05-13T10:19:00Z

LGTM

Varinara · 2022-05-19T11:07:45Z

All comments have been addressed. @kssenii please have a look.

kssenii · 2022-05-19T13:18:00Z

programs/disks/disks.cpp

+    global_context->setApplicationType(Context::ApplicationType::DISKS);
+    global_context->setPath(path);
+
+    command_descriptions[command_arguments[0]]->execute(command_arguments, global_context, config());


let's save command_arguments[0] into a separate variable command_name in class when validating command arguments . And same separate variable for command_arguments, so that they do not contain command name, only command arguments.

kssenii · 2022-05-19T13:18:51Z

programs/disks/disks.cpp

+        exit(0);
+    }
+
+    if (command_arguments.size() == 0 || !supported_commands.count(command_arguments[0]))


Suggested change

if (command_arguments.size() == 0 || !supported_commands.count(command_arguments[0]))

if (command_arguments.size() == 0 || !supported_commands.contains(command_arguments[0]))

kssenii · 2022-05-19T13:24:18Z

programs/disks/CommandCopy.h

+        if (path_from[0] == '/')
+            path_from.erase(0, 1);
+        if (path_to[0] == '/')
+            path_to.erase(0, 1);


why is it needed?

I thought the input format of command should looks like command /PATH
disk->getPath() gives the path in the format /PATH/
that's why I erased the first symbol '/'

kssenii · 2022-05-19T13:39:50Z

programs/disks/CommandCopy.h

+        String full_path_from = (disk_name_from == "default"
+                                     ? ((fs::path(disk_from->getPath()) / "data/default") / path_from)
+                                     : (fs::path(disk_from->getPath()) / path_from));
+        String full_path_to = (disk_name_to == "default"
+                                   ? ((fs::path(disk_to->getPath()) / "data/default") / path_to)
+                                   : (fs::path(disk_to->getPath()) / path_to));


why need to add "data/default" ? fs::path(disk->getPath()) / path should suffice for any case

Varinara · 2022-05-23T12:28:39Z

Thanks for the comments @kssenii . Fixed

kssenii · 2022-05-25T10:22:35Z

programs/disks/CommandWrite.h

+        String path = (command_arguments.size() < 1
+                                ? ""
+                                : command_arguments[0]);


why do we allow empty path for write command?

kssenii · 2022-05-25T10:27:28Z

programs/disks/CommandRemove.h

+
+        DiskPtr disk = global_context->getDisk(disk_name);
+
+        String full_path = fs::path(disk->getPath()) / path;


Let's protect against forbidden paths. Need to check that (fs::absolute(disk->getPath()) / path).lexically_normal() is indeed inside disk->getPath()

Need to add this path validation in all places it is used (move checking into a separate method validatePath).

kssenii · 2022-05-25T10:28:10Z

programs/disks/CommandRead.h

+        String path = (command_arguments.size() < 1
+                                ? ""
+                                : command_arguments[0]);


Also here why allow empty path for read command?

kssenii · 2022-05-25T10:29:28Z

programs/disks/CommandNoCommand.h

+    void execute(
+        const std::vector<String> &,
+        const DB::ContextMutablePtr &,
+        const Poco::Util::AbstractConfiguration &) override{}


throw exception in this case?

kssenii · 2022-05-25T10:31:33Z

programs/disks/CommandLink.h

+        String path_from = (command_arguments.size() < 1
+                                ? ""
+                                : command_arguments[0]);
+        String path_to = (command_arguments.size() < 2
+                                ? ""
+                                : command_arguments[1]);


Would also be strange to allow empty paths here.

Varinara · 2022-05-30T17:56:19Z

Thanks, @kssenii . think Fixed

kssenii · 2022-05-30T18:36:33Z

programs/disks/CommandMove.cpp

+        Poco::Util::AbstractConfiguration &,
+        po::variables_map &) const override{}
+
+    void execute_impl(


Suggested change

void execute_impl(

void executeImpl(

should be like this by our style

Varinara · 2022-06-01T10:50:25Z

@kssenii Fixes have been made, failed tests seems to be unrelevant

kssenii

ok, these are last comments, let's fix this and merge

kssenii · 2022-06-02T10:24:44Z

programs/disks/CommandListDisks.cpp

+        for (const auto & [disk_name, disk] : global_context->getDisksMap())
+            disks_names.push_back(disk->getName());
+
+        for (const auto & disk_name : disks_names)
+            std::cout << disk_name << '\n';


Suggested change

for (const auto & [disk_name, disk] : global_context->getDisksMap())

disks_names.push_back(disk->getName());

for (const auto & disk_name : disks_names)

std::cout << disk_name << '\n';

for (const auto & [disk_name, _] : global_context->getDisksMap())

std::cout << disk_name << '\n';

kssenii · 2022-06-02T10:29:50Z

programs/disks/CommandWrite.cpp

+        String path_input = config.getString("input", "default");
+
+        std::unique_ptr<ReadBufferFromFileBase> in = std::make_unique<ReadBufferFromFileDescriptor>(STDIN_FILENO);
+        if (path_input != "default")
+        {
+            String full_path_input = fullPathWithValidate(disk, path_input);
+            in = disk->readFile(full_path_input);
+        }


Suggested change

String path_input = config.getString("input", "default");

std::unique_ptr<ReadBufferFromFileBase> in = std::make_unique<ReadBufferFromFileDescriptor>(STDIN_FILENO);

if (path_input != "default")

{

String full_path_input = fullPathWithValidate(disk, path_input);

in = disk->readFile(full_path_input);

}

String path_input = config.getString("input", "");

std::unique_ptr<ReadBufferFromFileBase> in;

if (path_input.empty())

{

in = std::make_unique<ReadBufferFromFileDescriptor>(STDIN_FILENO);

}

else

{

String full_path_input = fullPathWithValidate(disk, path_input);

in = disk->readFile(full_path_input);

}

kssenii · 2022-06-02T10:32:36Z

programs/disks/ICommand.cpp

+{
+    String full_path = (fs::absolute(disk->getPath()) / path).lexically_normal();
+    String disk_path = fs::path(disk->getPath());
+    if (full_path.find(disk_path) == String::npos)


starts_with?

kssenii · 2022-06-02T10:33:25Z

programs/disks/ICommand.cpp

+    String full_path = (fs::absolute(disk->getPath()) / path).lexically_normal();
+    String disk_path = fs::path(disk->getPath());
+    if (full_path.find(disk_path) == String::npos)
+        throw DB::Exception("Error path", DB::ErrorCodes::BAD_ARGUMENTS);


Suggested change

throw DB::Exception("Error path", DB::ErrorCodes::BAD_ARGUMENTS);

throw DB::Exception(DB::ErrorCodes::BAD_ARGUMENTS, "Path {} must be inside disk path {}", path, disk->getPath());

kssenii · 2022-06-02T10:34:28Z

programs/disks/CommandRead.cpp

+        String path_output = config.getString("output", "default");
+
+        if (path_output != "default")


Suggested change

String path_output = config.getString("output", "default");

if (path_output != "default")

String path_output = config.getString("output", "");

if (!path_output.empty())

Varinara · 2022-06-03T10:17:45Z

Fixes completed, test failures seem unrelated to the changes.@kssenii

kssenii

LGTM

will wait for some tests which are not finished yet (marked as failed now, but they will restart automatically as they failed because of ci reasons), at least waiting for all integration tests

kssenii · 2022-06-04T13:09:01Z

It crashes in debug build:

./clickhouse disks --config-file ~/ch-server/config.xml list-disks
libc++abi: terminating
[1]    1597275 IOT instruction (core dumped)  ./clickhouse disks --config-file ~/ch-server/config.xml list-disks

./clickhouse disks --config-file ~/ch-server/config.xml --disk s3disk  list .
libc++abi: terminating
[1]    1597889 IOT instruction (core dumped)  ./clickhouse disks --config-file ~/ch-server/config.xml --disk s3disk list .

UPDATE: the reason was in invalid connection to s3 which resulted in logical_error and termination in debug build.

may be allow config path at any position? this does not work:

./clickhouse disks list-disks --config-file ~/ch-server/config.xml
DB::Exception: Configuration file /etc/clickhouse-server/config.xml doesn't exist
[1]    1597229 IOT instruction (core dumped)  ./clickhouse disks list-disks --config-file ~/ch-server/config.xml

…k, copy, read, write) + tests

Varinara · 2022-06-06T15:52:15Z

Now can set config path at any position. @kssenii

kssenii · 2022-06-06T19:44:12Z

@Mergifyio update

mergify · 2022-06-06T19:44:33Z

update

✅ Branch has been successfully updated

kssenii self-assigned this Apr 8, 2022

robot-clickhouse added the pr-improvement Pull request with some product improvements label Apr 8, 2022

nikitamikhaylov added the can be tested Allows running workflows for external contributors label Apr 8, 2022

GrigoryPervakov reviewed Apr 8, 2022

View reviewed changes

GrigoryPervakov mentioned this pull request Apr 8, 2022

Remote disk managing tool #34998

Closed

Varinara marked this pull request as draft April 8, 2022 11:04

alexey-milovidov changed the title ~~Add feature disks(ls, C, list-disks, disk, help)~~ Add feature disks (ls, C, list-disks, disk, help) Apr 8, 2022

ianton-ru suggested changes Apr 15, 2022

View reviewed changes

GrigoryPervakov reviewed Apr 15, 2022

View reviewed changes

programs/disks/disks.h Outdated

namespace ErrorCodes

{

extern const int NOT_IMPLEMENTED;

Copy link

Contributor

GrigoryPervakov Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find usages of it

GrigoryPervakov reviewed Apr 15, 2022

View reviewed changes

Varinara force-pushed the master branch from c1d8e0e to 22c7198 Compare April 19, 2022 14:01

GrigoryPervakov reviewed Apr 21, 2022

View reviewed changes

kssenii reviewed Apr 24, 2022

View reviewed changes

kssenii reviewed May 8, 2022

View reviewed changes

Varinara marked this pull request as ready for review May 19, 2022 11:06

kssenii reviewed May 19, 2022

View reviewed changes

kssenii reviewed May 25, 2022

View reviewed changes

Varinara force-pushed the master branch 2 times, most recently from 7e1ced7 to c743ac8 Compare May 30, 2022 14:53

Varinara force-pushed the master branch from c743ac8 to 6085fd8 Compare May 30, 2022 14:55

kssenii reviewed May 30, 2022

View reviewed changes

kssenii reviewed Jun 2, 2022

View reviewed changes

Varinara force-pushed the master branch from 5f04ded to 25851d5 Compare June 2, 2022 11:31

kssenii approved these changes Jun 3, 2022

View reviewed changes

Varinara added 8 commits June 6, 2022 16:52

Add basic commands for disk tool (list-disks, list, move, remove, lin…

ed6e817

…k, copy, read, write) + tests

Corrections

5140970

Corrections

354ef2e

Corrections

f5d4e9c

Corrections

a330d3c

Corrections

e35d146

Fixe: allow config path at any position

6aa9e5d

Fixe2: allow config path at any position

1f8fab4

Varinara force-pushed the master branch from 1a98ce7 to 1f8fab4 Compare June 6, 2022 13:53

Merge branch 'master' into master

7a76a7a

kssenii merged commit 4272ca8 into ClickHouse:master Jun 7, 2022

		@@ -0,0 +1,29 @@
		#ifndef CLICKHOUSE_PATH_H
		#define CLICKHOUSE_PATH_H


		disk_test->listFiles(full_path, file_names);

		for (auto iter = file_names.begin(); iter != file_names.end(); iter++)

	.description = "List FILEs (the default disk by default)",
	.description = "List files (the default disk is used by default)",

	def exec_in_container(self, cmd, detach=False, nothrow=False, **kwargs):
	return self.cluster.exec_in_container(
	self.docker_id, cmd, detach, nothrow, **kwargs
	)

		@@ -55,6 +55,8 @@ option (ENABLE_CLICKHOUSE_KEEPER "ClickHouse alternative to ZooKeeper" ${ENABLE_

		option (ENABLE_CLICKHOUSE_KEEPER_CONVERTER "Util allows to convert ZooKeeper logs and snapshots into clickhouse-keeper snapshot" ${ENABLE_CLICKHOUSE_ALL})

		option (ENABLE_CLICKHOUSE_DISKS "Work with disks" ${ENABLE_CLICKHOUSE_ALL})

	option (ENABLE_CLICKHOUSE_DISKS "Work with disks" ${ENABLE_CLICKHOUSE_ALL})
	option (ENABLE_CLICKHOUSE_DISKS "A tool to manage disks" ${ENABLE_CLICKHOUSE_ALL})


		disk->listFiles(full_path, file_names);

		for (const auto &file_name : file_names)

	for (const auto &file_name : file_names)
	for (const auto & file_name : file_names)

	if (command_arguments.size() == 0 \|\| !supported_commands.count(command_arguments[0]))
	if (command_arguments.size() == 0 \|\| !supported_commands.contains(command_arguments[0]))


		DiskPtr disk = global_context->getDisk(disk_name);

		String full_path = fs::path(disk->getPath()) / path;

	throw DB::Exception("Error path", DB::ErrorCodes::BAD_ARGUMENTS);
	throw DB::Exception(DB::ErrorCodes::BAD_ARGUMENTS, "Path {} must be inside disk path {}", path, disk->getPath());

		String path_output = config.getString("output", "default");

		if (path_output != "default")

Add feature disks (ls, C, list-disks, disk, help) #36060

Add feature disks (ls, C, list-disks, disk, help) #36060

Conversation

Varinara commented Apr 8, 2022 • edited Loading

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Varinara commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrigoryPervakov Apr 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ianton-ru commented May 13, 2022

Varinara commented May 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Varinara commented May 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Varinara commented May 30, 2022

Choose a reason for hiding this comment

Varinara commented Jun 1, 2022

kssenii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Varinara commented Jun 3, 2022 • edited Loading

kssenii left a comment

Choose a reason for hiding this comment

kssenii commented Jun 4, 2022 • edited Loading

Varinara commented Jun 6, 2022

kssenii commented Jun 6, 2022

mergify bot commented Jun 6, 2022

✅ Branch has been successfully updated

Varinara commented Apr 8, 2022 •

edited

Loading

GrigoryPervakov Apr 15, 2022 •

edited

Loading

Varinara commented Jun 3, 2022 •

edited

Loading

kssenii commented Jun 4, 2022 •

edited

Loading