-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password #34738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dd1c4e
to
0cbfd71
Compare
a9a234b
to
aa8494a
Compare
@vitlibar,I see that 6 checks are failing which doesn't seems to be related to my changes. |
vitlibar
reviewed
Mar 8, 2022
2d9156e
to
318b7da
Compare
8c67c9b
to
d0c0ece
Compare
34e0f48
to
3f031df
Compare
@vitlibar , Thanks for merging the PR. |
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Sep 11, 2023
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-feature
Pull request with new product feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry :
A new settings called <allow_plaintext_password><allow_no_password> is added in server configuration which on/off insecure AUTH_TYPE plaintext-password and no_password.
By default the property is set to true which means authType Plaintext_password & NO_password is allowed.
Detailed description / Documentation draft:
Currently clickhouse user can store the password in configuration file and user access entity can be created using SQL statements identified with Plaintext_passowrd and no_password. Good password management guidelines require that a password never be stored in plaintext. Password submission in cleartext format OR using no password authentication is always considered as insecure.
This feature hardens the user configuration and allows admin to disable insecure auth_type (plaintext_password and no_password).
<allow_plaintext_and_no_password>0</allow_plaintext_and_no_password>
If this property is unset in clickhouse server configuration, ALTER/CREATE users are not allowed without AUTH_TYPE and IDENTIFIED WITH NO_PASSWORD/PLAINTEXT_PASSWORD.
Additionally , Users existed in system.users with no-password and plaintext_password AuthType won't be able to login if this property is unset i.e plaintext and no_password are not allowed.
Issue #33953