Use ActionsDAG in KeyCondition #25563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se into use-dag-in-key-condition
robot-clickhouse
added
doc-alert
pr-feature
KochetovNicolai
changed the title
robot-ch-test-poll1
added
pr-improvement
novikd
approved these changes
Aug 4, 2022
| @@ -94,6 +94,9 @@ class QueryPipelineBuilder | |||
| /// Changes the number of output ports if needed. Adds ResizeTransform. | |||
| void resize(size_t num_streams, bool force = false, bool strict = false); | |||
|
|
|||
| /// Concat some ports to have no more then size outputs. | |||
| void narrow(size_t size); | |||
There was a problem hiding this comment.
Yes, I will add comment
| return res; | ||
| } | ||
|
|
||
| bool getConstant(const Block & block_with_constants, Field & out_value, DataTypePtr & out_type) const |
There was a problem hiding this comment.
Suggested change
| bool getConstant(const Block & block_with_constants, Field & out_value, DataTypePtr & out_type) const | |
| bool tryGetConstant(const Block & block_with_constants, Field & out_value, DataTypePtr & out_type) const |
| case (ActionsDAG::ActionType::ARRAY_JOIN): | ||
| { | ||
| const auto & arg = cloneASTWithInversionPushDown(*node.children.front(), inverted_dag, to_inverted, context, false); | ||
| res = &inverted_dag.addArrayJoin(arg, ""); |
| @@ -5885,6 +5902,8 @@ std::optional<ProjectionCandidate> MergeTreeData::getQueryProcessingStageWithAgg | |||
| selected_candidate->aggregate_descriptions = select.getQueryAnalyzer()->aggregates(); | |||
| } | |||
|
|
|||
| /// Just in case, reset prewhere info calculated from projection. | |||
| query_info.prewhere_info.reset(); | |||
| auto current_info = query_info.order_optimizer->getInputOrder(storage_metadata_snapshot, modified_context); | ||
| if (it == selected_tables.begin()) | ||
| input_sorting_info = current_info; | ||
| else if (!current_info || (input_sorting_info && *current_info != *input_sorting_info)) |
There was a problem hiding this comment.
Maybe we can remember a common prefix?
|
@novikd I want to have |
|
it introduced a bug #40599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Change the way how PK is analyzed for MergeTree.