Fix multiline queries with comments in interactive mode #17565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
This was referenced Nov 30, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2020
vitlibar
pushed a commit
that referenced
this pull request
Nov 30, 2020
Backport #17565 to 20.11: Fix multiline queries with comments in interactive mode
vitlibar
pushed a commit
that referenced
this pull request
Nov 30, 2020
Backport #17565 to 20.10: Fix multiline queries with comments in interactive mode
vitlibar
pushed a commit
that referenced
this pull request
Dec 1, 2020
Backport #17565 to 20.12: Fix multiline queries with comments in interactive mode
vitlibar
pushed a commit
that referenced
this pull request
Dec 1, 2020
Backport #17565 to 20.9: Fix multiline queries with comments in interactive mode
|
It breaked multiline history navigation. |
This was referenced Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When clickhouse-client is used in interactive mode with multiline queries, single line comment was erronously extended till the end of query. This fixes #13654.